Fixes made during stream E295 #563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
w23
commented
Sep 14, 2023
•
w23
commented
- Fixes Particles from weapons do not fade smoothly #441
- Fixes Sprite lerping does not work in ray traced mode #433
- Fixes Crash if you explode three times, die and reload #562
It Just Works™ even with raytracing, as RT just blends everything (including coplanar sprites) order-dependent correctly. Fixes #433
For #562 investigation
Returning `0` instead of `ALO_ALLOC_FAILED` let to API consumers believe that allocation was successful. This lead to asserts failing when trying to free such allocations. Makes #562 not crash (but miss studio models anyway)
Entity data gets reallocate on every NewMap regardless of whether it was a load from a save. Thus all entity pointers and data are invalidated. EntityData keeps things using pointers as keys. Make sure it is properly cleared on `R_NewMap()` Fixes #562
Fixing pool allocator to properly signal allocation failure uncovered an existing issue where we were lacking enough memory for dynamic model BLASes on Linux/amdgpu. Erroneously the same memory region was used for >1 BLAS. Surprisingly this hasn't led to any noticeable issues so far. Increasing accels buffer size fixes the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.