-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Accept header to application/vc+ld+json #605
Conversation
As we discussed on the call --
An In this scenario, an In sum: |
I'll be splitting out the data integrity proof updates, with sd-jwt work pending resolution in the jose-cose working group |
@@ -156,7 +156,7 @@ | |||
"header": [ | |||
{ | |||
"key": "Accept", | |||
"value": "application/json", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would remove this part
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you say more? In this case the Accept
header is on a Verify
request, so just represents a preference that the verification response be in json format, right?
@rhofvendahl is there anything outstanding for this PR? |
@mkhraisha Once Orie's suggestion is resolved this should be ready to merge. There are still some references to |
Related PR: w3c/vc-jose-cose#186 ^ in case this PR is not merged, the current PR will continue to be correct. |
This PR updates references to
Accept
header in "Create Credentials" requests to use eitherapplication/vc+ld+json
orapplication/vc+ld+json+sd-jwt
, as discussed in issue #574.EDIT: using
application/sd-jwt
rather thanapplication/vc+ld+json+sd-jwt
, as discussed in 11/7/23 trace call.