Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added codelist 196:93 for certifierCredential ONIX equivalent #88

Merged
merged 5 commits into from
Jul 18, 2023

Conversation

clapierre
Copy link
Collaborator

Adding support for certifierCredential in light of Gramham's email

From Graham Bell:
For the use case you describe (a generic link – same link for all certified publishers), 93 is probably more appropriate.

If there a ‘deeper' URL that can point to an individual publisher’s credentials? Or one that provides any detail beyond ‘I am certified’? Maybe even a list of certified publishers? That’s what you’d use 94 for.

I will also add this example (using 93 and the generic link, unless there is another option) to our Implementation and Best Practice Guide.

@w3cbot
Copy link

w3cbot commented Jul 13, 2023

iherman marked as non substantive for IPR from ash-nazg.

@@ -118,7 +118,7 @@ <h2>EPUB and ONIX</h2>
</tr>
<tr>
<td>certifierCredential</td>
<td></td>
<td><a href="https://ns.editeur.org/onix/en/196">List: 196</a>; Code: 93: Carries the URL of a web page belonging to the organisation responsible for compliance testing and certification of the product</td>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like the description for the ProductFormFeatureDescription element that goes with code 93. As far as the crosswalk goes, shouldn't we only note this as "Code 93: Compliance certification by"?

@mattgarrish
Copy link
Member

It looks like this fixes #61.

@clapierre
Copy link
Collaborator Author

As far as #61, I agree except it also mentions this could potentially also fix certifiedBy, which I don't think it does. as Benetech has two GCA evaluations ours plus eBoundCanada. Both of which point to our GCA Credential URL, but ours is "CertifiedBy: Benetech" the other is "CertifiedBy: Benetech via eBoundCanada". This nuance is still to be addressed.

@madeleinerothberg
Copy link
Collaborator

I'm not well-informed on this one. If Charles and Matt think it works, then it's fine with me.

@mattgarrish
Copy link
Member

mattgarrish commented Jul 14, 2023

I'm still concerned that we're not using the official name for Code 93. All the other mappings use the exact headings listed on this page: https://ns.editeur.org/onix/en/196

What if I go through the table and update all those links to go their definition pages rather than have them all going to the generic link?

For example, this definition could be:

List 196: Code 93: Compliance certification by

Would that work for you @clapierre ?

I only see additional explanations added for the complicated values, like the access modes, that involve multiple code values (although even those list the official headings for each).

@clapierre
Copy link
Collaborator Author

Sure I think thats a great idea Matt.

@mattgarrish
Copy link
Member

I've gone through and updated all the linking and added titles for any codes that were missing. I also linked all the conformance and schema.org values to their definitions so you can get more info on whichever property you're unfamiliar with.

@w3cbot
Copy link

w3cbot commented Jul 18, 2023

deniak marked as substantive for IPR from ash-nazg.

@mattgarrish mattgarrish merged commit 106662f into main Jul 18, 2023
@mattgarrish mattgarrish deleted the Adding-certifierCredential-link branch July 18, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants