-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clarify which dictionary members are valid in context of encoding/decoding and type #187
Comments
re: invalid behavior, I propose we throw a TypeError. The alternative of ignoring invalid inputs seems less learnable for authors. @drkron, FYI - I think this is something we should spec and implement w/ shipping of encodingInfo(). Please feel free to take the lead. |
I'm now back from holiday and catching up on ongoing issues. I think that TypeError sounds good. I can create a PR for this once the fix for spatialScalabilty lands. What do you think of just specifying when it's applicable for each member? |
SGTM. If not applicable -> TypeError |
MC was initially designed for MSE and file decoding (and mostly that's what folks have shipped). The spec has since grown to include webrtc, but many dictionary members only apply in the original MSE / file decoding contexts (for now). We should clarify that in the spec and maybe throw TypeError (or at least log a warning) if folks provide a member that isn't valid in the given context.
Here's my quick analysis of existing dictionary members:
Video
Audio
KeySystemConfig (was #166)
Aside: some of these things may be at-risk for dropping entirely.
The text was updated successfully, but these errors were encountered: