Lighting correction #53
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eehakkin
force-pushed
the
feature/lighting-correction
branch
from
ebaeeff to
70669ff
Compare
alvestrand
reviewed
Aug 25, 2022
eehakkin
force-pushed
the
feature/lighting-correction
branch
2 times, most recently
from
bf3fadf to
b2854f0
Compare
eehakkin
force-pushed
the
feature/lighting-correction
branch
from
a83a0cf to
5becfcc
Compare
|
This issue was mentioned in WEBRTCWG-2023-02-21 (Page 46) |
alvestrand
reviewed
Sep 21, 2023
| <p>When the "lightingCorrection" setting is set to <code>true</code> by | ||
| the <a>ApplyConstraints algorithm</a>, the UA will attempt to correct | ||
| human face and background lighting balance so that human faces are | ||
| not underexposed. |
|
Probably should have a note saying that the meaning of "correct" is platform dependent and not controllable by the application. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lighting correction corrects lighting balance between a foreground person and the background so that the foreground person is underexposed.
Please see #49 (comment) why a constrainable property is most suitable for the purpose.
Preview | Diff