Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert color-gamut to be a single value. #311

Merged
merged 2 commits into from
Oct 13, 2023
Merged

Convert color-gamut to be a single value. #311

merged 2 commits into from
Oct 13, 2023

Conversation

markafoltz
Copy link
Contributor

@markafoltz markafoltz commented Sep 8, 2023

Fixes #305. This converts color-gamuts to be a single value, not a list, as support for a wider gamut implies support for narrower gamuts.


Preview | Diff

@markafoltz
Copy link
Contributor Author

@chrisn, I recall you helped in #300 which declares color capabilities in the protocol, and this is a follow-up to that PR.

Copy link
Contributor

@baylesj baylesj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % feedback.

index.bs Outdated Show resolved Hide resolved
@chrisn
Copy link
Member

chrisn commented Oct 13, 2023

@mfoltzgoogle Thank you! I'll come back with review comments (on this and other PRs) as soon as I can.

@markafoltz markafoltz merged commit dcc0efb into main Oct 13, 2023
1 check passed
@markafoltz
Copy link
Contributor Author

markafoltz commented Oct 13, 2023

@baylesj - I merged based on your LGTM; note you can explicitly approve PRs using the dropdown in the GitHub UI.

@markafoltz markafoltz deleted the fix-color-gamut branch October 13, 2023 22:26
github-actions bot added a commit that referenced this pull request Oct 13, 2023
SHA: dcc0efb
Reason: push, by mfoltzgoogle

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

color-gamuts could be a single value and not a list
3 participants