Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo in example #155

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Conversation

troggy
Copy link
Contributor

@troggy troggy commented Apr 14, 2024

@troggy
Copy link
Contributor Author

troggy commented Apr 14, 2024

insignificant

@troggy troggy closed this Apr 14, 2024
@chrisn
Copy link
Member

chrisn commented Apr 15, 2024

This looks like a valid correction, worth including in the spec.

@tidoust tidoust reopened this Apr 15, 2024
@w3cbot
Copy link

w3cbot commented Apr 15, 2024

tidoust marked as non substantive for IPR from ash-nazg.

@tidoust
Copy link
Member

tidoust commented Apr 15, 2024

I took the liberty to re-open the pull request, which I'll now merge.

I hope the IPR bot that runs on pull requests did not scare you away @troggy. We don't need you to commit to anything to fix typos in particular. We would only start pondering things if the update touched on a normative part of the specification.

@tidoust tidoust merged commit c06e93d into w3c:main Apr 15, 2024
2 checks passed
github-actions bot added a commit that referenced this pull request Apr 15, 2024
SHA: c06e93d
Reason: push, by tidoust

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@anssiko anssiko self-requested a review April 15, 2024 09:03
Copy link
Member

@anssiko anssiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@troggy thanks for the contribution and attention to detail.

Example code we include in the specs should be correct so we won't frustrate any web developers who try the API out for the first time, starting with the examples. But sometimes bugs get in spec examples too.

Typo fixes in examples are very helpful and well received contributions. We all know how frustrating it is when a piece of code you grab from the spec does not work. It should just work. Please do not hesitate to submit further improvements to the examples, or even propose new examples!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants