This repository has been archived by the owner on Sep 19, 2018. It is now read-only.
Discourage race condition in Service Workers #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Invoke the ExtendableEvent's `waitUntil` method in order to discourage user agents from terminating service workers while asynchronous tests are running (which would interfere with test execution). Although the user agent is still free to terminate workers when execution "exceeds imposed time limits," this precaution should prevent interference for the most common cases. > # 2.1.1. Lifetime > > The lifetime of a service worker is tied to the execution lifetime of > events and not references held by service worker clients to the > ServiceWorker object. > > A user agent may terminate service workers at any time it: > > - Has no event to handle. > - Detects abnormal operation: such as infinite loops and tasks exceeding > imposed time limits (if any) while handling the events. https://w3c.github.io/ServiceWorker/#service-worker-lifetime
|
After some discussion on the public-webapps mailing list, I've requested feedback on this general pattern in the Service Worker specification's issue tracker: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Invoke the ExtendableEvent's
waitUntilmethod in order to discourageuser agents from terminating service workers while asynchronous tests
are running (which would interfere with test execution). Although the
user agent is still free to terminate workers when execution "exceeds
imposed time limits," this precaution should prevent interference for
the most common cases.
https://w3c.github.io/ServiceWorker/#service-worker-lifetime
@mkruisselbrink @mattto @wanderview Does this seem reasonable to you?
This change is