-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removing remaining references to JSON #1182
Conversation
Co-authored-by: Dave Longley <[email protected]>
inline comments (<code>//</code>) and the use of ellipsis (<code>...</code>) | ||
to denote information that adds little value to the example. Implementers are | ||
cautioned to remove this content if they desire to use the information as | ||
valid JSON or JSON-LD. | ||
valid. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
valid. | |
a valid document. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, but noting that I'm a bit on the fence about removing this language, as that is how some implementations (including some of Digital Bazaar's processing pipelines), handle the VC as it is coming into or retrieved from our systems. We do, when it matters, do full JSON-LD processing, but that is not always necessary to perform. As long as we don't suggest that full JSON-LD processing is always required, this PR is fine. We might want to move a variation of this text to the implementation guide to ensure that developers know that it's ok to 1) ensure the order of the @context
entries, and then 2) process as ordinary JSON, in the circumstances where you don't need to check the signature yet, or when the signature has been checked and you know that you're working w/ good data.
Keep in mind that if |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm requesting changes until the structured suffixes details are resolved sufficiently to protect implementers from the confusion that would arise from removing these references while not defining how the suffixes are processed.
@OR13 what concrete details on the structured suffixes do you want to be resolved? multiple suffixes draft in IETF and how |
@Sakurann I guess you are right, the problem will be... if I am approving, with the hope that does not happen. |
@Sakurann, waiting on a typo fix before merging: https://github.com/w3c/vc-data-model/pull/1182/files#r1249374162 |
The issue was discussed in a meeting on 2023-07-11
View the transcript1.7. removing remaining references to JSON (pr vc-data-model#1182)See github pull request vc-data-model#1182. Brent Zundel: this P.R removes differentiation between JSONLD and JSON. Has relatively broad approval. |
The issue was discussed in a meeting on 2023-07-11
View the transcript1.7. removing remaining references to JSON (pr vc-data-model#1182)See github pull request vc-data-model#1182. Brent Zundel: this P.R removes differentiation between JSONLD and JSON. Has relatively broad approval. |
Actually, the suggestion is Editorial, and made by me, so I can just merge at this point and make the change, which is what I'll do. |
Editorial, multiple reviews, changes requested and made, no objections, merging. |
The issue was discussed in a meeting on 2023-07-11
View the transcript1.7. removing remaining references to JSON (pr vc-data-model#1182)See github pull request vc-data-model#1182. Brent Zundel: this P.R removes differentiation between JSONLD and JSON. Has relatively broad approval. |
Clarifying that "There is no such thing as
vc+json
", addressing #1044 and preventing future confusion like in #1088 after it was merged. As part of that clarification, it references JSON-LD spec directly wrt the processing of@context
, since if the base media type isvc+ld+json
, it needs to be a valid JSON-LD.Preview | Diff