Fix example 24 with enveloped credential

[decentralgabe]

Fix #217

---

Preview | Diff

[iherman]

Unfortunately, Github does not let me to comment directly on lines that were not edited. I believe the example should be:

{ 
  "@context": ["https://www.w3.org/ns/credentials/v2"], 
  "type": ["VerifiablePresentation"], 
  "holder": "urn:ietf:params:oauth:jwk-thumbprint:sha-256:_Fpfe27AuGmEljZE9s2lw2UH-qrZLRFNrWbJrWIe4SI", 
  "verifiableCredential": [{ 
    "@context": ["https://www.w3.org/ns/credentials/v2"], 
    "type": ["EnvelopedVerifiableCredential"], 
    "id": "data:application/vcld+json+sd-jwt;eyJhbGciOiJFUzM4NCIsImtpZCI6IlNJM1JITm91aDhvODFOT09OUFFVQUw3RWdaLWtJNl94ajlvUkV2WDF4T3ciLCJ0eXAiOiJ2YytsZCtqc29uK3NkLWp3dCIsImN0eSI6InZjK2xkK2pzb24ifQ.eyJAY29udGV4dCI6WyJodHRwczovL3d3dy53My5vcmcvbnMvY3JlZGVudGlhbHMvdjIiLCJodHRwczovL3d3dy53My5vcmcvbnMvY3JlZGVudGlhbHMvZXhhbXBsZXMvdjIiXSwiaXNzdWVyIjoiaHR0cHM6Ly91bml2ZXJzaXR5LmV4YW1wbGUvaXNzdWVycy81NjUwNDkiLCJ2YWxpZEZyb20iOiIyMDEwLTAxLTAxVDE5OjIzOjI0WiIsImNyZWRlbnRpYWxTY2hlbWEiOnsiX3NkIjpbIkU3dU1sSWFyS29iYXJTdEZGRjctZm5qaV9sQVdnM3BGMkV5dVc4dWFYakUiLCJYelRaSVgyNGdDSWxSQVFHclFoNU5FRm1XWkQtZ3Z3dkIybzB5Y0FwNFZzIl19LCJjcmVkZW50aWFsU3ViamVjdCI6eyJkZWdyZWUiOnsibmFtZSI6IkJhY2hlbG9yIG9mIFNjaWVuY2UgYW5kIEFydHMiLCJfc2QiOlsiT3oxUEZIMG0tWk9TdEhwUVZyeGlmVlpKRzhvNmlQQmNnLVZ2SXQwd2plcyJdfSwiX3NkIjpbIkVZQ1daMTZZMHB5X1VNNzRHU3NVYU9zT19mdDExTlVSaFFUTS1TT1lFTVEiXX0sIl9zZCI6WyJqT055NnZUbGNvVlAzM25oSTdERGN3ekVka3d2R3VVRXlLUjdrWEVLd3VVIiwid21BdHpwc0dRbDJveS1PY2JrSEVZcE8xb3BoX3VYcWVWVTRKekF0aFFibyJdLCJfc2RfYWxnIjoic2hhLTI1NiIsImlzcyI6Imh0dHBzOi8vdW5pdmVyc2l0eS5leGFtcGxlL2lzc3VlcnMvNTY1MDQ5IiwiaWF0IjoxNjk3Mjg5OTk2LCJleHAiOjE3Mjg5MTIzOTYsImNuZiI6eyJqd2siOnsia3R5IjoiRUMiLCJjcnYiOiJQLTM4NCIsImFsZyI6IkVTMzg0IiwieCI6InZFdV84WGxZT0ZFU2hTcVRpZ2JSYWduZ0ZGM1p5U0xrclNHekh3azFBT1loanhlazVhV21HY2UwZU05S0pWOEIiLCJ5IjoiRUpNY2czWXBzUTB3M2RLNHlVa25QczE1Z0lsY2Yyay03dzFKLTNlYlBiOERENmQtUkhBeGUwMDkzSWpfdTRCOSJ9fX0.rYzbxb6j1dwop8_s491iArVVJNm6A6C3b742gOm_qYO3zdkyQU4_VxxOSJ8ECcmWj2r5KyiCNC1ojfO4Yms-zBsjt7PoMYpYWBplsqXpiIvnehmM7D0eOLi40uHXki0X~WyJSWTg1YTZNMmEwX3VDWlFTVGZmTFdRIiwgImlkIiwgImh0dHA6Ly91bml2ZXJzaXR5LmV4YW1wbGUvY3JlZGVudGlhbHMvMTg3MiJd~WyJMeG5GYTBXVm8wRUluVy1QdS1fd1dRIiwgInR5cGUiLCBbIlZlcmlmaWFibGVDcmVkZW50aWFsIiwgIkV4YW1wbGVBbHVtbmlDcmVkZW50aWFsIl1d~WyJUQVdrakpCaVpxdC1rVU54X1EweUJBIiwgImlkIiwgImh0dHBzOi8vZXhhbXBsZS5vcmcvZXhhbXBsZXMvZGVncmVlLmpzb24iXQ~WyJTd2xuZFpPZzZEZ1ZERFp5X0RvYVFBIiwgInR5cGUiLCAiSnNvblNjaGVtYSJd~WyJuSnJlU3E1Nzg3RGZMSDJCbU03cXFRIiwgImlkIiwgImRpZDpleGFtcGxlOjEyMyJd~WyIxMjNNd3hNcHRiek02YUk2aW03ME1RIiwgInR5cGUiLCAiQmFjaGVsb3JEZWdyZWUiXQ" 
  }] 
}

All the other properties are defined on a Verifiable Credential only, and not on an Enveloped one. (I cannot check whether the value of the Data URI is correct, I let this to you...)

cc: @msporny

[decentralgabe]

@iherman should be good now!

[iherman]

You forgot to remove the issuer property...

I approve, provided that change is accepted.

[Sakurann]

I think it would be a good idea to fix not just the example, but enhance the description/requirements too. because the text leading to the examples was not clear either.

[decentralgabe]

Going to change two things:

1. Add an example of a secure enveloped credential presentation
2. Add text / descriptions
3. Make sure there are examples of SD JWTs with disclosures in the presentation

[iherman]

The issue was discussed in a meeting on 2024-01-24

• no resolutions were taken

View the transcript

1.1. Fix example 24 with enveloped credential (pr vc-jose-cose#219)

See github pull request vc-jose-cose#219.

Brent Zundel: Ivan has suggested changes on this one that I believe have been addressed. There's a suggestion from Kristina about enhancing the description. It looks like a straightforward editorial change.

Gabe Cohen: I do agree with Kristina's comments that we need an additional example that shows a secured envelope's presentation and it's lacking some text. I will do that in this issue and I'll note that I'll add this information.

Brent Zundel: Anything else on 219?

[decentralgabe]

Updated as described. The first example will render using Orie's plugin and the second is the original example that will render as-is.

Separately I have opened this issue related to #214 which will fix how these examples get rendered. Should be good to merge on approval.

[brentzundel]

@iherman can you re-review?

[iherman]

I do not understand. While, from my point of view, example 24 looks o.k., I do not see any difference between examples 24 and 25, except that one is coloured and the other is not. What am I missing?

[decentralgabe]

@iherman this has to do with the rendering issue that we are working to fix. the first will be rendered with multiple tabs showing issued/signed/revealed/etc the second will appear as is. I'd prefer to merge this as the rendering fix is a parallel effort.

#214

[iherman]

@iherman this has to do with the rendering issue that we are working to fix. the first will be rendered with multiple tabs showing issued/signed/revealed/etc the second will appear as is. I'd prefer to merge this as the rendering fix is a parallel effort.

Ok. But then we should probably wait with the merge of this PR to get #214 settled, so that we would get a full picture.

[decentralgabe]

this will be rebased and merged after #241 which is blocked by #239

[decentralgabe]

this has been fixed by #241