Update examples securing Verifiable Presentations #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
decentralgabe
force-pushed
the
issue-222
branch
from
032018d to
7df3214
Compare
davidlehn
reviewed
Jan 29, 2024
iherman
requested changes
Jan 30, 2024
Co-authored-by: Ivan Herman <[email protected]>
iherman
approved these changes
Jan 31, 2024
TallTed
approved these changes
Jan 31, 2024
brentzundel
approved these changes
Feb 8, 2024
|
This change adds the media type of sd-jwt for the enveloped VC, but currently there is no sd-jwt VC example in the draft. It would be better if the enveloped VC was pure JSON protected and the media type reflected this. |
|
@David-Chadwick merging this for agility. please open/add another issue if you feel this is insufficient. |
|
I have added this issue as a comment to #204 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #222
For both JOSE and COSE
Preview | Diff