-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove YAML; add disclosures to SD-JWT examples; add protected headers #272
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A little cross-file consistency
Co-authored-by: Ted Thibodeau Jr <[email protected]>
Not sure if/how to comment here but from a quick look at the Preview the examples don't look to be self consistent or syntactically correct. |
@bc-pi I see some issues too, I'll fix them and comment here when they're addressed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#270 (comment) has some (perhaps overly) candid thoughts
@bc-pi it's rare I screw up so bad I leave someone speechless 😂 - my apologies I've fixed the code, if you refresh https://pr-preview.s3.amazonaws.com/w3c/vc-jose-cose/pull/272.html you'll see it in a better state. I may have to do some work on the nested disclosures, though I still believe this is an improvement. Hopefully it's at least to a place where you can articulate what's still not right. |
#273 going to close and re-open ... rendering is not working as expected |
Fix #269 and replaces #270
Fix #271
Does not yet address #264 which I will take in a subsequent PR to add multiple tabs to the standalone SD-JWT example
for the combined example I feel this would be too much to display
Preview | Diff