update all examples to use proper data urls #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentzundel
reviewed
Aug 12, 2024
index.html
Outdated
| @@ -2156,12 +2156,12 @@ <h2 id="presentations">Presentations</h2> | |||
| }, | |||
| { | |||
| "@context": "https://www.w3.org/ns/credentials/v2", | |||
| "id": "data:application/vc-ld+jwt;eyVjV...RMjU", | |||
| "id": "data:application/vc-ld+jwt;base64url,ebyVjV...RMjU", | |||
There was a problem hiding this comment.
did a 'b' get added here accidentally or on purpose?
There was a problem hiding this comment.
nice spot, this was an accident
There was a problem hiding this comment.
fixed 4dbee09
There was a problem hiding this comment.
I don't think this is right, the base64url should not be present -- JWTs/SD-JWTs are already a text-based format (that happen to use base64url encoding internally, but there are also . and ~ chars, etc.).
There was a problem hiding this comment.
@dlongley in what was merged I removed base64url and just kept ,
decentralgabe
commented
Aug 12, 2024
brentzundel
approved these changes
Aug 12, 2024
added 2 commits
August 12, 2024 18:41
decentralgabe
force-pushed
the
fix-issue-289
branch
from
4dbee09 to
0af32f3
Compare
selfissued
approved these changes
Aug 13, 2024
decentralgabe
added
class 1
class 2
class 3
class 4
and removed
class 2
class 3
class 4
labels
|
This is an example change (class 1) - and has approval from editors, so I will be merging it now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #289
cc: @timothee-haudebourg
Preview | Diff