Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore qualifying language about vc and vp claims #307

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

selfissued
Copy link
Collaborator

@selfissued selfissued commented Sep 27, 2024

Restores qualifying language inadvertently deleted by #304.

Fixes #305


Preview | Diff

@selfissued selfissued added the editorial Editorial changes only label Sep 27, 2024
@TallTed
Copy link
Member

TallTed commented Sep 27, 2024

Sadly, I'm now even more worried about what else may have been lost by similar activities as wiped this line out.

@TallTed
Copy link
Member

TallTed commented Sep 27, 2024

Note that this fixes line ~318.

There are two other similarly phrased paragraphs, at line ~607 and ~1179, which I found by viewing this file on the main branch, and searching for MUST NOT be present. (Something else has just changed, as ~1179 is no longer present, but ~607 still remains.)

@selfissued
Copy link
Collaborator Author

The occurrence of

The JWT Claim Names vc and vp MUST NOT be present.

that you're referring to @TallTed is in the 3.1.3 JOSE Header Parameters and JWT Claims section, which is within the With JOSE section, so taken in context, it's clear that the statement only applies to VCs secured with JOSE, and so is fine as-is.

PR #304 didn't change that text.

@TallTed
Copy link
Member

TallTed commented Sep 27, 2024

in the 3.1.3 JOSE Header Parameters and JWT Claims section, which is within the With JOSE section

OK, I think I can live with that.

@decentralgabe
Copy link
Collaborator

Purely editorial. Approved and merging.

@decentralgabe decentralgabe merged commit 34d979d into w3c:main Sep 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial Editorial changes only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vc-jose-cose cannot restrict use of specific JWT Claim Names "in any JWT Claim Set"
3 participants