Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct term JWT Claims Set #312

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

selfissued
Copy link
Collaborator

@selfissued selfissued commented Oct 9, 2024

Note that the SD-JWT spec also uses the term JWT Claims Set.


Preview | Diff

@selfissued selfissued added the editorial Editorial changes only label Oct 9, 2024
@decentralgabe
Copy link
Collaborator

purely editorial. merging.

@decentralgabe decentralgabe merged commit cc317ae into w3c:main Oct 9, 2024
2 checks passed
@TallTed
Copy link
Member

TallTed commented Oct 9, 2024

Note that this was acknowledged when I requested that all claims set be changed to claim set, which request was accepted and acted upon.

I know, "JWT Claims Set" is what was used in RFC7519. It's terrible English. Both "Set of JWT Claims" and "JWT Claim Set" have the intended meaning, and would put the singulars and plurals in the right places. RFC7519 did the right thing with "claim names" (it never says "claims names" nor "claims name"). I can't guess why it got "Claims Set" wrong. But it is.

Note that "JWT claims set" is also inconsistent within this JOSE/COSE document with "JSON claim set". I have found other RFCs that include both "claims set" and "claim set".

I can't imagine what rule would declare "claims set" and "claim set" both correct. Sadly, Google has hidden their "result" counts, so I can no longer make any representation of current usage on the web.

I won't lie down in the road on this, but it sets my teeth on edge, so I'm asking that it be changed, throughout.

@selfissued
Copy link
Collaborator Author

In defense of the name "JWT Claims Set", this is a shorthand for "a set of JWT claims". The term "JWT Claim Set" would be syntactically incorrect in the same way that "a set of JWT claim" would be. (They're both missing the required plural.)

@TallTed
Copy link
Member

TallTed commented Oct 10, 2024

The term "JWT Claim Set" would be syntactically incorrect in the same way that "a set of JWT claim" would be. (They're both missing the required plural.)

This is incorrect analysis.

A "JWT Claim Set" is a "Set of JWT Claims", in the same way that a "rulebook" (or "rule book") is a "book of rules", or a "toolbox" is a "box of tools".

There are dozens if not hundreds of examples like these. I'm sure you can think of several if you take a few minutes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial Editorial changes only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants