Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update cr to Dec 19 #322

Merged
merged 4 commits into from
Dec 16, 2024
Merged

update cr to Dec 19 #322

merged 4 commits into from
Dec 16, 2024

Conversation

decentralgabe
Copy link
Collaborator

@decentralgabe decentralgabe commented Dec 13, 2024

Also changed my affiliation


Preview | Diff

Copy link
Member

@iherman iherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Gabe.

However: the generated CR versions gives, as a closing date for the review, the 19th of December :-). I would propose to put 31st of January: we are getting into the holiday period and, in many places around the World, that includes the first week of January.

Furthermore, there are link checker errors, namely broken fragments:

https://www.w3.org/TR/vc-data-model-2.0/#example-a-simple-example-of-the-contents-of-a-verifiable-credential (lines 1527, 1930, 2271)

While I could change the end dates manually, I did not know which example you are referring to in the VCDM, so I would prefer you take care of all the changes.

@msporny I copy you on this to use the same 31st of January for the other CR2 end dates.

@msporny
Copy link
Member

msporny commented Dec 14, 2024

@msporny I copy you on this to use the same 31st of January for the other CR2 end dates.

I set Jan 19th 2025 as the CR End date for the documents I generated yesterday (and have many more things going on today/tomorrow wrt. spec work where changing the date yet again, regenerating everything, HTML/CSS/link-checking everything all over again, is a non-starter).

Jan 19th sets the minimum timeframe for CR; I think we're fine there. Up to Gabe if he wants to use that date or a later one. I suggest we all use the same date.

@decentralgabe
Copy link
Collaborator Author

I've updated the end date to Jan 19

@decentralgabe
Copy link
Collaborator Author

I've fixed the links and updated references to 'controlled identifier document' except for the short name which isn't available yet.

@iherman iherman self-requested a review December 16, 2024 08:10
@decentralgabe decentralgabe merged commit b635459 into main Dec 16, 2024
2 checks passed
@decentralgabe decentralgabe deleted the cr-prep branch December 16, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants