Allow newly created codecs to be reclaimed if the system is out of resources #836
Conversation
index.src.html
Outdated
| @@ -6035,7 +6035,8 @@ | |||
| received a call to `encode()`, `decode()`, `configure()`, `flush()` or `reset()` | |||
| in the past `10 seconds`, or has called its `output()` callback in the past `10 | |||
| seconds`. Addionally, {{VideoEncoder}}s are considered [=active=] if they are | |||
| making progress in encoding queued {{VideoFrame}}s. | |||
| making progress in encoding queued {{VideoFrame}}s. Newly created codecs are not | |||
| considered [=active=] until they call an output callback for the first time. | |||
There was a problem hiding this comment.
Are we sure? I'd have expected input not output here.
There was a problem hiding this comment.
I think that "output callback" is intended. A suggestion: change "they call an output callback for the first time" to "the first output callback" to make this more clear.
A decode() or encode() method could error if resources have been reclaimed.
There was a problem hiding this comment.
Right, what I'm saying is that this is in contradiction with the previous sentence.
There was a problem hiding this comment.
Ah, yes. Just calling encode() or decode() is not sufficient if they error (which they can do if resources are not available).
There was a problem hiding this comment.
The sentence that I added is intended to mark a newly created coded inactive before it actually got some work done. I do realize that it looks like the new condition contradicts the previous one. I expect that readers will realize that the last condition supersedes the previous ones, but if it looks misleading I'm open to suggestions.
There was a problem hiding this comment.
Yeah, we can't have contradiction in normative text. Let's proceed step by step here:
- Say one of the method mentioned is called. Two things can happen: it can succeed or fail. If it fails, the codec isn't considered active, abort those steps.
- A message is queued. Two things can happen: it can execute or note. If it cannot execute, it means that other things are executing, and so the codec is already active, abort those steps.
- If it executes, then we can mark it as active, we'll e.g. configure a decoder, or submit a frame for encode/decode. It can be that there will be no output for some time: decoder and encoder latency can be very large, and encoding time can also be extremely long.
- When an output callback fires, we should also consider the codec as active, to let script enqueue other tasks, as it is often how the encoding/decoding is driven.
what is important is therefore if one of the methods enqueue a control message successfully OR having an output callback, and that should be our criteria for marking a codec as active.
There was a problem hiding this comment.
Until the codec successfully processes at least one input it can't be considered fully initialized, because encoding or decoding might use lazy resource allocation.
It means that we can't really be sure that we have sufficient system resources until we have the first output ready.
That's why I think that merely having a control message enqueues shouldn't be enough for the codec to be marked as active. After producing the first output processing control messages should be enough to keep the codec active.
There was a problem hiding this comment.
"Accepts", not process, I'd say, but sure. There can be seconds between the two.
index.src.html
Outdated
| @@ -6035,7 +6035,8 @@ | |||
| received a call to `encode()`, `decode()`, `configure()`, `flush()` or `reset()` | |||
| in the past `10 seconds`, or has called its `output()` callback in the past `10 | |||
| seconds`. Addionally, {{VideoEncoder}}s are considered [=active=] if they are | |||
| making progress in encoding queued {{VideoFrame}}s. | |||
| making progress in encoding queued {{VideoFrame}}s. Newly created codecs are not | |||
| considered [=active=] until they call an output callback for the first time. | |||
There was a problem hiding this comment.
I think that "output callback" is intended. A suggestion: change "they call an output callback for the first time" to "the first output callback" to make this more clear.
A decode() or encode() method could error if resources have been reclaimed.
SHA: a2770c1 Reason: push, by Djuffin Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: a2770c1 Reason: push, by sandersdan Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: a2770c1 Reason: push, by sandersdan Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: a2770c1 Reason: push, by sandersdan Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: a2770c1 Reason: push, by sandersdan Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: a2770c1 Reason: push, by sandersdan Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This PR addresses #669
Preview | Diff