Add a codec match algorithm for setCodecPreferences #2847
Merged
+56
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-ivar
requested changes
Mar 28, 2023
jan-ivar
reviewed
Mar 29, 2023
jan-ivar
reviewed
Mar 30, 2023
|
But overall as expressed earlier, I have some concerns about an A B comparison across codec types. @alvestrand has some useful comments in w3c/media-capabilities#185 (comment) that I think are clarifying. |
Also remove impossible to implement steps in setCodecPreferences, as it's always possible to modify a dictionary. Fixes w3c#2845.
jan-ivar
reviewed
Mar 30, 2023
henbos
approved these changes
Mar 30, 2023
Co-authored-by: Jan-Ivar Bruaroey <[email protected]>
jan-ivar
approved these changes
Mar 30, 2023
23 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also remove impossible to implement steps in setCodecPreferences, as it's always possible to modify a dictionary.
Fixes #2845.
Preview | Diff