Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Milestone-1 Delivery for MeProtocol #1065

Merged
merged 5 commits into from
Dec 8, 2023

Conversation

AgentPoles
Copy link
Contributor

Milestone Delivery Checklist

  • The milestone-delivery-template.md has been copied and updated.
  • This pull request is being made by the same account as the accepted application.
  • I have disclosed any and all sources of reused code in the submitted repositories and have done my due diligence to meet its license requirements.
  • In case of acceptance, an invoice must be submitted and the payment will be transferred to the Polkadot/fiat account provided in the application.
  • The delivery is according to the Guidelines for Milestone Deliverables.

Link to the application pull request: w3f/Grants-Program#1340

@keeganquigley keeganquigley self-assigned this Nov 28, 2023
@keeganquigley
Copy link
Contributor

Hi @AgentPoles, apologies for the delay. The unit tests are all passing, albeit with a lot of warnings. Also, I had to use cargo +nightly test because it was complaining about not being supported by the stable toolchain. Same with cargo +nightly clippy. Are these warnings meant to be ignored during this first phase?

Unfortunately, I am have trouble building the Docker image:

docker build -t my-rust-environment .

[+] Building 0.4s (6/11)
 => [internal] load build definition from Dockerfile                                                                 0.0s
 => => transferring dockerfile: 752B                                                                                 0.0s
 => [internal] load .dockerignore                                                                                    0.0s
 => => transferring context: 2B                                                                                      0.0s
 => [internal] load metadata for docker.io/library/node:16.15.1                                                      0.4s
 => CANCELED [1/7] FROM docker.io/library/node:16.15.1@sha256:a13d2d2aec7f0dae18a52ca4d38b592e45a45cc4456ffab82e5ff  0.0s
 => => resolve docker.io/library/node:16.15.1@sha256:a13d2d2aec7f0dae18a52ca4d38b592e45a45cc4456ffab82e5ff10d8a53d0  0.0s
 => => sha256:a13d2d2aec7f0dae18a52ca4d38b592e45a45cc4456ffab82e5ff10d8a53d042 1.21kB / 1.21kB                       0.0s
 => => sha256:bc263109e229d53373522bd6e33fdba6d3bfcf77e206ffe5ef9176be57e8b89a 2.21kB / 2.21kB                       0.0s
 => => sha256:7bfe40651606734d05c5ed76e674e38b83a8754a40752570d9138dc90dec7da7 7.75kB / 7.75kB                       0.0s
 => [internal] load build context                                                                                    0.0s
 => => transferring context: 1.00kB                                                                                  0.0s
 => ERROR [2/7] COPY ./typechain-generated /app/typechain-generated                                                  0.0s
------
 > [2/7] COPY ./typechain-generated /app/typechain-generated:
------
failed to compute cache key: failed to calculate checksum of ref 3f71efc0-eddb-44f4-9e7c-7d0dbe37e813::fif4m6t1e6opjjelr8qsk6k01: "/typechain-generated": not found

I tried on both Mac and Ubuntu 20.04. I have the substrate-contracts-node running using version 0.35.0. Can you look into this? In the meantime I will try building the contracts manually.

@keeganquigley
Copy link
Contributor

I tried building the contracts manually but they all fail to compile due to the same error:

warning: `global` (lib) generated 75 warnings (run `cargo fix --lib -p global` to apply 62 suggestions)
   Compiling oracle v0.1.0 (/private/var/folders/6_/b7tdvp0d6h779ktj0h92w5km0000gn/T/cargo-contract_johhjA)
    Finished release [optimized] target(s) in 22.40s
 [2/4] Post processing code
ERROR: Loading of original wasm failed

Caused by:
    0: Loading of wasm module at '/Users/keeganquigley/rusty-protocol-v0.1/contracts/modules/services/oracle/target/ink/wasm32-unknown-unknown/release/oracle.wasm' failed
    1: Unknown opcode 192

Therefore I am currently unable to complete the e2e testing section.

@AgentPoles
Copy link
Contributor Author

Hi @keeganquigley

  1. for the cargo test, yes please you have to use nightly for now, because we are heavily dependent on the Openbrush library and that requires us to use nightly. Also yes please, the warnings can be ignored for now.
  2. For the docker image, the ./typechain-generated was ignored from git during our push to that branch, we have pushed that now and updated the dockerfile appropriately so everything should work fine now.
  3. For the manual building of the contracts, you would need to enter the folder for each module and build from there, but we have actually generated the ./typechain and added it to the push for you, so you might not need to go through that process anymore.

Please let me know if you have any further issues, thanks a lot!

@keeganquigley
Copy link
Contributor

Thanks for your patience @AgentPoles I was able to get everything running, and you can find my final eval here. I'm happy to pass the milestone and good luck on the next one!

@keeganquigley keeganquigley merged commit ae6e768 into w3f:master Dec 8, 2023
6 checks passed
Copy link

github-actions bot commented Dec 8, 2023

🪙 Please fill out the invoice form in order to initiate the payment process. Thank you!

@AgentPoles
Copy link
Contributor Author

Hi @keeganquigley . I appreciate you for your patience with us despite our many setbacks. We will deliver one of the best innovations in this space. Thanks a lot once again.

@semuelle
Copy link
Member

@AgentPoles, have you submitted an invoice yet?

@AgentPoles
Copy link
Contributor Author

Hi @semuelle, yes please we did via our CEO, Robert Wesley. Here is what the invoice looks like
Web3 Me Protocol Invoice 1.pdf

@semuelle
Copy link
Member

Thanks, received, @AgentPoles. However, the payment address doesn't match the one in the grant agreement. Could you update either one to match the other? Thanks! If you update the payment address in the contract, could you update it to one for Polkadot Asset Hub?

@AgentPoles
Copy link
Contributor Author

AgentPoles commented Dec 22, 2023

Hi @semuelle. Sorry I was away. Here is the updated Invoice:

Web3 Me Protocol Invoice3.pdf

Updating payment asset from USDC to DOT

@AgentPoles
Copy link
Contributor Author

I have raised the PR to update the payment details to DOT with a polkadot address instead of USDC on Ethereum.

@semuelle
Copy link
Member

@AgentPoles, the address in the invoice you submitted through the form doesn't match the address in the amendment. The one in the invoice you linke above matches, though. Could you submit that one or change the amendment to match the invoice? Also, you are making a pull request from an old fork. Ideally, it would only contain the change of the address, not the previous amendment as well. It's causing merging issues.

@AgentPoles
Copy link
Contributor Author

AgentPoles commented Dec 22, 2023

Woops sorry @semuelle my bad on the PR. Raised a new one. Would update you once we make the change to the submitted form. Thanks a lot!

@AgentPoles
Copy link
Contributor Author

Hi @semuelle the invoice submission via the form has now been updated! Thanks a lot!

@AgentPoles
Copy link
Contributor Author

Hi @semuelle Just checking in on the payment update. Thanks a lot!

@RouvenP
Copy link

RouvenP commented Jan 4, 2024

hi @AgentPoles first of all, apologies for the delay - we will try to get the payment to you asap. before we can proceed we would need an invoice that shows the same USDC address as you have in your application. In your application you listed 0xB35da2E7380a2580Acdc0ca5DEa9e2B152155e84. If you prefer to receive USDC on Polkadot we would need you to update the application accordingly. let us know if anything is unclear. Thanks!

@RouvenP
Copy link

RouvenP commented Jan 4, 2024

hi @AgentPoles I was looking at an old application, everything is fine with the invoice. We will proceed with the payment as soon as possible and let you know as soon as done.

@RouvenP
Copy link

RouvenP commented Jan 4, 2024

hi @AgentPoles we just transferred the payment.

@AgentPoles
Copy link
Contributor Author

AgentPoles commented Jan 8, 2024

Hi @RouvenP thanks a lot, please we haven't received it yet in the account. Can you send a TxReceipt / TxHash to confirm. Thanks a lot!

@RouvenP
Copy link

RouvenP commented Jan 9, 2024

Hi @AgentPoles sure - see here. Did you check on Polkadot or on Assethub?

@AgentPoles
Copy link
Contributor Author

Oh thanks a lot @RouvenP, we were expecting to capture it in DOT not USDC, but we can see from the TXHash that it was paid in USDC. We actually provided a Coinbase address since it is easier to do Payroll from there. We are in communication with coinbase now to resolve this. Thanks a lot @RouvenP, will keep you updated.

@RouvenP
Copy link

RouvenP commented Jan 11, 2024

sorry to hear @AgentPoles! Seems there was a misunderstanding - please let us know if there's anything we can help with.

@AgentPoles
Copy link
Contributor Author

Yea @RouvenP We have been following up closely with coinbase for the past weeks, but they are persistent on the fact that they are not able to help us recover the USDC from the wallet, that it is strictly for DOT. This doesn't make any sense to us though as we can clearly see the asset in the wallet: https://assethub-polkadot.subscan.io/account/14K4XzpMBxGp8NiCKMWAwzjFMLcAKjakXooqHtVEC6WoaeTq , but here is an attachment of our conversation email thread with them.
Reply Case 17644876 1.pdf. Would be really glad to receive some help.

@RouvenP
Copy link

RouvenP commented Jan 22, 2024

hi @AgentPoles sorry to hear that - I'll take it up internally and will get back to you as soon as possible.

@AgentPoles
Copy link
Contributor Author

thanks a lot @RouvenP 🙏🙏🙏

@RouvenP
Copy link

RouvenP commented Jan 23, 2024

hi @AgentPoles we are in the process of reaching out to Coinbase and will keep you posted.

@AgentPoles
Copy link
Contributor Author

thanks a lot @RouvenP , we are sincerely grateful! 🙏🙏🙏

@AgentPoles
Copy link
Contributor Author

Hello @RouvenP please just checking if there is any update on this. Thanks a lot!

@RouvenP
Copy link

RouvenP commented Jan 29, 2024

hi @AgentPoles we're still waiting for feedback. We'll follow up again and will get back to you within the next 1-2 days hopefully.

@AgentPoles
Copy link
Contributor Author

alright @RouvenP thanks a lot!

@RouvenP
Copy link

RouvenP commented Jan 31, 2024

hi @AgentPoles

Unfortunately, our attempts to recover the funds were unsuccessful. We will send another payment but would ask you to

  1. update your application with new payment details for one of the following currencies: DOT-USDC, DOT-USDT, CHF, EUR, USD
  2. and, once 1) was approved, submit a new invoice with the new payment details?

If Coinbase were to implement DOT-USDC support in the future, we would reach out to you asking you to return the funds from your Coinbase account to us.

Please let us know if you have any questions. Thanks!
Rouven

@AgentPoles
Copy link
Contributor Author

Hi @RouvenP this is great, thanks a lot, we would update right away.
Please Just to confirm for the USD, it would be a normal bank account with a traditional bank?

@semuelle
Copy link
Member

semuelle commented Feb 2, 2024

Just to confirm for the USD, it would be a normal bank account with a traditional bank?

Yes. For bank details, see instructions in our template.

@AgentPoles
Copy link
Contributor Author

Thank a lot @semuelle, added it here!

@AgentPoles
Copy link
Contributor Author

Hello @semuelle @keeganquigley @RouvenP please checking in on this , thanks a lot 🙏

@RouvenP
Copy link

RouvenP commented Feb 16, 2024

hi @AgentPoles could you submit a new invoice with the updated payment instructions? we will then process the invoice as soon as possible. Apologies for not making this clear in the first place!

@AgentPoles
Copy link
Contributor Author

🙏

@RouvenP
Copy link

RouvenP commented Feb 19, 2024

hi @AgentPoles confirming that we received your invoice. the payment will be included in this weeks payment run and should hit your account this Friday or early next week.

@AgentPoles
Copy link
Contributor Author

alright thanks a lot! 🙏

@RouvenP
Copy link

RouvenP commented Feb 23, 2024

hi @AgentPoles the payment left our account today. you should receive it early next week. please let us know if that is not the case. thank you!

@AgentPoles
Copy link
Contributor Author

Hi @RouvenP, I can confirm we have received the credit. Thank you very much 🙏

@RouvenP
Copy link

RouvenP commented Feb 29, 2024

hi @AgentPoles thanks for confirming. Glad to hear this is solved!

@AgentPoles AgentPoles mentioned this pull request May 21, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants