WIP on getting app-prop-viewer to load. Seems to get to component now… #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r font and added component to load the external css files
…, but no visual Signed-off-by: 1000TurquoisePogs <[email protected]>
| @@ -56,7 +56,7 @@ | |||
| "sourceMap": true | |||
| } | |||
| }, | |||
| "defaultConfiguration": "production" | |||
| "defaultConfiguration": "development" | |||
There was a problem hiding this comment.
development, i need to see the source in the browser to debug.
it can be production when we're ready.
| @@ -9,7 +9,7 @@ | |||
| "scripts": { | |||
| "build:externals": "webpack --progress --config webpack.externals.js", | |||
| "start": "webpack --watch --progress", | |||
There was a problem hiding this comment.
You can also update start script to be
"ng build --watch"
|
I am getting this, is this expected UI?
The console is very promising, some App Prop Viewer things are being loaded but not sure if I'm seeing what I'm supposed to |
|
small addition: zowe#606 |
yes, but i dont know why it doesnt get further. perhaps some step is missing. |
wadkarsatish
force-pushed
the
v2.x/staging
branch
2 times, most recently
from
86ba78a to
6430bd8
Compare
wadkarsatish
force-pushed
the
v2.x/staging
branch
from
6430bd8 to
13145ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ng buildto the package.json build instruction so you cannpm run buildbecause I never put npm tools in my global path and we dont tell people to either.Before this, the app would try to do a GET on
web/@angular/core/core.jsAfter, it makes no request at all.
Neither does desktop.js. The "externals" seem to work in the same way they always have, but now without the need for a separate "externals.js" and "externals-main.js"
NOTE:
ng buildremovesrequire.jsfrom the web folder. After building you still need tocp node_modules/requirejs/require.js web/...