Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract GENEActiv starttime from first page header. #57

Merged
merged 12 commits into from
Jan 24, 2024

Conversation

vincentvanhees
Copy link
Member

@vincentvanhees vincentvanhees commented Jan 23, 2024

This PR:

@vincentvanhees vincentvanhees requested a review from l-k- January 23, 2024 16:17
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (5a791ea) 90.01% compared to head (72db846) 89.82%.
Report is 1 commits behind head on main.

❗ Current head 72db846 differs from pull request most recent head 1daeb84. Consider uploading reports for the commit 1daeb84 to get more accurate results

Files Patch % Lines
R/readGENEActiv.R 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #57      +/-   ##
==========================================
- Coverage   90.01%   89.82%   -0.19%     
==========================================
  Files           9        9              
  Lines         901      904       +3     
==========================================
+ Hits          811      812       +1     
- Misses         90       92       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

R/readGENEActiv.R Outdated Show resolved Hide resolved
- omit attempt to use file header start time
- omit +5 that is no longer needed because apparently this was the offset in the header timestamp
@vincentvanhees vincentvanhees merged commit 23e7a8b into main Jan 24, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GENEActiv: when starttime is "2010-09-16 09:10:00:000" use first page time instead.
2 participants