Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: panic if it is not possible to obtain the merkle root #873

Merged
merged 3 commits into from
Nov 9, 2023

Conversation

richard-ramos
Copy link
Member

Description

Panics if while retrieving the merkle root, there's a failure. Having an error in RLN at this stage will probably mean that we have an inconsistent state in the merkle tree, so it's better to stop the program execution

Issue

closes #738

@status-im-auto
Copy link

status-im-auto commented Nov 7, 2023

Jenkins Builds

Click to see older builds (12)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 2c414b0 #1 2023-11-07 20:09:44 ~1 min nix-flake 📄log
✖️ 2c414b0 #1 2023-11-07 20:10:20 ~2 min tests 📄log
✔️ 2c414b0 #1 2023-11-07 20:10:32 ~2 min linux 📦deb
✔️ 2c414b0 #1 2023-11-07 20:11:50 ~4 min android 📦tgz
✔️ 2c414b0 #1 2023-11-07 20:11:55 ~4 min tests 📄log
✔️ 2c414b0 #1 2023-11-07 20:13:15 ~5 min ios 📦tgz
✔️ 7060c18 #2 2023-11-08 16:11:52 ~1 min tests 📄log
✔️ 7060c18 #2 2023-11-08 16:12:35 ~1 min nix-flake 📄log
✔️ 7060c18 #2 2023-11-08 16:13:11 ~2 min linux 📦deb
✔️ 7060c18 #2 2023-11-08 16:14:07 ~3 min tests 📄log
✔️ 7060c18 #2 2023-11-08 16:14:11 ~3 min android 📦tgz
✔️ 7060c18 #2 2023-11-08 16:14:38 ~3 min ios 📦tgz
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ cb93efb #3 2023-11-08 16:14:20 ~2 min tests 📄log
✔️ cb93efb #3 2023-11-08 16:14:26 ~1 min linux 📦deb
✔️ cb93efb #3 2023-11-08 16:14:53 ~2 min nix-flake 📄log
✔️ cb93efb #3 2023-11-08 16:15:13 ~4 min ios 📦tgz
✔️ cb93efb #3 2023-11-08 16:17:41 ~3 min tests 📄log
✔️ cb93efb #3 2023-11-08 16:17:56 ~3 min android 📦tgz
✔️ 80dc5b1 #4 2023-11-09 20:12:36 ~1 min linux 📦deb
✔️ 80dc5b1 #4 2023-11-09 20:13:16 ~1 min tests 📄log
✔️ 80dc5b1 #4 2023-11-09 20:13:22 ~1 min nix-flake 📄log
✔️ 80dc5b1 #4 2023-11-09 20:14:40 ~3 min android 📦tgz
✔️ 80dc5b1 #4 2023-11-09 20:14:59 ~3 min tests 📄log
✔️ 80dc5b1 #4 2023-11-09 20:15:29 ~4 min ios 📦tgz

Copy link
Collaborator

@chaitanyaprem chaitanyaprem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richard-ramos richard-ramos merged commit 5aa4d57 into master Nov 9, 2023
11 checks passed
@richard-ramos richard-ramos deleted the panic-get-root branch November 9, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

bug: handle errors generated in gm.rootTracker.UpdateLatestRoot(pair.Key.(uint64))
3 participants