Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add an enhanced bloom filter library #3

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

shash256
Copy link
Collaborator

@shash256 shash256 commented Nov 9, 2024

This PR adds an enhanced version of the Bloom filter implementation originally from https://github.com/boydgreenfield/nimrod-bloom.

Key changes:

  • Modernized for current Nim (updated from Nimrod)
  • Added configurable hash implementation (Nim's built-in hash (FarmHash) by default, and a better performing 128-bit MurmurHash3)
  • Improved test coverage with comprehensive hash implementation tests
  • Better error handling, optimizations for large-scale usage and parameter validation

The implementation provides both standard (using Nim's built-in hash) and extended (using MurmurHash3) modes, to be usable for different use cases.

@shash256 shash256 self-assigned this Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant