Lint more redundant activation events (microsoft#173186)

* `onWalkthrough` * `onTerminalQuickFixRequest` * `onTerminalProfile` * `onRenderer`
walles · Feb 2, 2023 · b424430 · b424430
1 parent 8922a50
commit b424430
Showing 1 changed file with 37 additions and 1 deletion.
diff --git a/extensions/extension-editing/src/extensionLinter.ts b/extensions/extension-editing/src/extensionLinter.ts
@@ -17,7 +17,7 @@ const allowedBadgeProviders: string[] = (product.extensionAllowedBadgeProviders
 const allowedBadgeProvidersRegex: RegExp[] = (product.extensionAllowedBadgeProvidersRegex || []).map((r: string) => new RegExp(r));
 const extensionEnabledApiProposals: Record<string, string[]> = product.extensionEnabledApiProposals ?? {};
 const reservedImplicitActivationEventPrefixes = ['onNotebookSerializer:'];
-const redundantImplicitActivationEventPrefixes = ['onLanguage:', 'onView:', 'onAuthenticationRequest:', 'onCommand:', 'onCustomEditor:'];
+const redundantImplicitActivationEventPrefixes = ['onLanguage:', 'onView:', 'onAuthenticationRequest:', 'onCommand:', 'onCustomEditor:', 'onTerminalProfile:', 'onRenderer:', 'onTerminalQuickFixRequest:', 'onWalkthrough:'];
 
 function isTrustedSVGSource(uri: Uri): boolean {
 	return allowedBadgeProviders.includes(uri.authority.toLowerCase()) || allowedBadgeProvidersRegex.some(r => r.test(uri.toString()));
@@ -453,5 +453,41 @@ function parseImplicitActivationEvents(tree: JsonNode): Set<string> {
 		});
 	});
 
+	// walkthroughs
+	const walkthroughs = findNodeAtLocation(tree, ['contributes', 'walkthroughs']);
+	walkthroughs?.children?.forEach(child => {
+		const id = findNodeAtLocation(child, ['id']);
+		if (id && id.type === 'string') {
+			activationEvents.add(`onWalkthrough:${id.value}`);
+		}
+	});
+
+	// notebookRenderers
+	const notebookRenderers = findNodeAtLocation(tree, ['contributes', 'notebookRenderer']);
+	notebookRenderers?.children?.forEach(child => {
+		const id = findNodeAtLocation(child, ['id']);
+		if (id && id.type === 'string') {
+			activationEvents.add(`onRenderer:${id.value}`);
+		}
+	});
+
+	// terminalProfiles
+	const terminalProfiles = findNodeAtLocation(tree, ['contributes', 'terminal', 'profiles']);
+	terminalProfiles?.children?.forEach(child => {
+		const id = findNodeAtLocation(child, ['id']);
+		if (id && id.type === 'string') {
+			activationEvents.add(`onTerminalProfile:${id.value}`);
+		}
+	});
+
+	// terminalQuickFixes
+	const terminalQuickFixes = findNodeAtLocation(tree, ['contributes', 'terminal', 'quickFixes']);
+	terminalQuickFixes?.children?.forEach(child => {
+		const id = findNodeAtLocation(child, ['id']);
+		if (id && id.type === 'string') {
+			activationEvents.add(`onTerminalQuickFixRequest:${id.value}`);
+		}
+	});
+
 	return activationEvents;
 }