Issue #157. implement CloudFormation RollbackTriggers. #188
Conversation
| Tags []*string `awsName:"Tags" awsType:"awstagslice" templateName:"tags"` | ||
| PolicyBody *string `awsName:"StackPolicyBody" awsType:"awsstr"` | ||
| StackFile *string `templateName:"stack-file"` | ||
| RollbackConfigurations *cloudformation.RollbackConfiguration `awsName:"RollbackConfiguration" awsType:"awsrollbackconfig"` |
There was a problem hiding this comment.
Could you try to remove the awsrollbackconfig definition entirely, meaning here in the metadata (awsType:"awsrollbackconfig") and in the setters.go file above (more playing the role of a stub I guess)?
I am not sure it is needed during the runtime but it should not be according to what you do with the RollbackConfigurations field.
There was a problem hiding this comment.
I tried, unfortunately then RollbackConfigurations not being passed to the Update request payload.
|
Thanks for implementing this latest feature from AWS in awless! I am a bit worried about the Anyway have you tested that in real life and is it working well for you? |
aws/doc/paramsdoc.go
Outdated
| "policy-file": "The path to the file containing the stack policy body", | ||
| "template-file": "The path to the file containing the template body with a minimum size of 1 byte and a maximum size of 51,200 bytes", | ||
| "stack-file": "The path to the file containing Parameters/Tags/StackPolices definition (http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/continuous-delivery-codepipeline-cfn-artifacts.html#w2ab2c13c15c15). Values passed via CLI has higher priority than ones defined in StackFile", | ||
| "rollback-triggers": "List of ClodwatchAlarm Arns to monitor during and after creation", |
|
@simcap I thought it needs to be implemented via setters but I didn't see the proper way to use them to create |
|
@trane9991 Coming back on that, I might have a solution so that it will be more robust. Also I will write the corresponding acceptance test so that we know if we are on the right track. I think I have write rights on this PR. Let's try to make this PR and the other you just created part of the next release v0.1.10 |
|
@trane9991 I wrote the acceptance test for the new params, so that at least we have a guarantee on how we want it to work regarding the implementation. You can now cherry pick (or any other way), the following commit e626663 and integrate it in this PR. We can then merge it to master I will subsequently code an implementation that do not do params injection in the before run step. Thanks! |
|
Simpler, I will merge it now and add the acceptance test myself. |
from template at the injection step instead of the BeforeRun step. See #188
|
@simcap sorry for troubles, I was very busy last days and didn't have time to look here. |
|
@trane9991 No worries! I am side tracked as well on other stuff. Also, if you want I can wait a bit so that your last PR can make it to the v0.1.10 that is due in the next few days. The PR was basically lacking a unit test on the main method I think ... if it was feasible. |
|
@simcap |
|
@trane9991 Actually, I just remembered I am off next week. Since there a lot of improvements in the v.0.1.10 and it is long overdue, we will release before the week end. But if you tell me that this PR has been well tested live on your terminal and that you are happy with it, I will merge it and you can add the unit test later on. (If you do test a bit on your terminal a bit try to pull the latest master (which will included my update on rollback triggers.) Let me know. |
|
@simcap it is tested, but not as well as I want it to. Go ahead and release it without that PR, I will do more live testing on my CI workflow and we can put it into the v0.1.11. |
This PR implements RollbackTriggers for CloudFormation. Issue #157
Feature announcment
API Documentation