fix: Define mock client using special example URL

wandelbotsgmbh · Aug 20, 2024 · b26d737 · b26d737
1 parent feb7b84
commit b26d737
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 19 deletions.
diff --git a/src/NovaClient.ts b/src/NovaClient.ts
@@ -13,7 +13,7 @@ export type NovaClientConfig = {
    * Url of the deployed Nova instance to connect to
    * e.g. https://saeattii.instance.wandelbots.io
    */
-  instanceUrl: string
+  instanceUrl: string | "https://mock.example.com"
 
   /**
    * Identifier of the cell on the Nova instance to connect this client to.
@@ -30,13 +30,6 @@ export type NovaClientConfig = {
    * Password for basic auth to the Nova instance.
    */
   password?: string
-
-  /**
-   * EXPERIMENTAL - For testing purposes. If true, the client won't connect to a Nova
-   * instance at all, and will instead use its own internal, heavily simplified mock replica
-   * to respond to requests.
-   */
-  mock?: boolean
 } & Omit<Configuration, "isJsonMime" | "basePath">
 
 type NovaClientConfigWithDefaults = NovaClientConfig & { cellId: string }
@@ -57,7 +50,7 @@ export class NovaClient {
       ...config,
     }
 
-    if (this.config.mock) {
+    if (this.config.instanceUrl === "https://mock.example.com") {
       this.mock = new MockNovaInstance()
     }
 

diff --git a/test/basic.test.ts b/test/basic.test.ts
@@ -5,8 +5,7 @@ import { NovaClient } from "../dist"
 
 test("things compile and initialize", async () => {
   const nova = new NovaClient({
-    instanceUrl: "https://nova.mock",
-    mock: true,
+    instanceUrl: "https://mock.example.com",
   })
 
   expect(nova.config.cellId).toBe("cell")

diff --git a/test/jogging.test.ts b/test/jogging.test.ts
@@ -5,7 +5,6 @@ import { NovaClient } from "../dist"
 
 test("things compile and initialize", async () => {
   const nova = new NovaClient({
-    instanceUrl: "https://nova.mock",
-    mock: true,
+    instanceUrl: "https://mock.example.com",
   })
 })
diff --git a/test/motionStream.test.ts b/test/motionStream.test.ts
@@ -5,8 +5,7 @@ import { NovaClient } from "../dist"
 
 test("motion stream", async () => {
   const nova = new NovaClient({
-    instanceUrl: "https://nova.mock",
-    mock: true,
+    instanceUrl: "https://mock.example.com",
   })
 
   const motionStream = await nova.connectMotionStream("0@mock-ur5e")
@@ -20,6 +19,6 @@ test("motion stream", async () => {
   await motionStream.motionStateSocket.firstMessage()
 
   expect(motionStream.motionStateSocket.url).toBe(
-    "wss://nova.mock/api/v1/cells/cell/motion-groups/0@mock-ur5e/state-stream?tcp=foo",
+    "wss://mock.example.com/api/v1/cells/cell/motion-groups/0@mock-ur5e/state-stream?tcp=foo",
   )
 })
diff --git a/test/websockets.test.ts b/test/websockets.test.ts
@@ -5,16 +5,15 @@ import { NovaClient } from "../dist"
 
 test("websocket handling", async () => {
   const nova = new NovaClient({
-    instanceUrl: "https://nova.mock",
-    mock: true,
+    instanceUrl: "https://mock.example.com",
   })
 
   // Check that we turn a path into a websocket URL correctly
   const ws = nova.openReconnectingWebsocket(
     "/motion-groups/0@mock-ur5e/state-stream",
   )
   expect(ws.url).toBe(
-    "wss://nova.mock/api/v1/cells/cell/motion-groups/0@mock-ur5e/state-stream",
+    "wss://mock.example.com/api/v1/cells/cell/motion-groups/0@mock-ur5e/state-stream",
   )
 
   // Opening the same websocket again should return the same object