Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(RPS-1004): handle https, add some convenience methods #15

Merged
merged 8 commits into from
Dec 23, 2024
Merged

feat(RPS-1004): handle https, add some convenience methods #15

merged 8 commits into from
Dec 23, 2024

Conversation

biering
Copy link
Collaborator

@biering biering commented Dec 20, 2024 •
edited
Loading

  • handle https and improve gateway creation
  • conform env variables from ADX
  • added tcps() and tcp_names() method
  • added controllers() method
  • make tcp in get_state() optional -> returns flange pose
  • updated examples accordingly

@biering biering self-assigned this Dec 20, 2024
langenhagen
langenhagen approved these changes Dec 20, 2024
View reviewed changes
Copy link
Collaborator

@langenhagen langenhagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

bompo
bompo approved these changes Dec 20, 2024
View reviewed changes
examples/03_move_and_set_ios.py Show resolved Hide resolved
examples/02_plan_and_execute.py Show resolved Hide resolved
nova/core/motion_group.py Show resolved Hide resolved
nova/core/motion_group.py Outdated Show resolved Hide resolved
nova/core/motion_group.py Outdated Show resolved Hide resolved
nova/gateway.py Show resolved Hide resolved
@biering biering changed the title feat: handle https, add some convenience methods feat(RPS-1004): handle https, add some convenience methods Dec 23, 2024
@biering biering merged commit e46cc90 into main Dec 23, 2024
3 checks passed
@biering biering deleted the feat/review branch December 23, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mahsumdemirwb mahsumdemirwb mahsumdemirwb approved these changes

@langenhagen langenhagen langenhagen approved these changes

@bompo bompo bompo approved these changes

@patrick-wbots patrick-wbots Awaiting requested review from patrick-wbots

Assignees

@biering biering

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@biering @bompo @langenhagen @mahsumdemirwb