support bg color #94
Draft
support bg color #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Running experiment on sagemaker with git sha cd7417b |
|
Training job support-bg-color-cd7417b-230713-054144-tat-train-baseline created |
|
Running experiment on sagemaker with git sha cd7417b |
|
Training job support-bg-color-cd7417b-230713-054228-tat-truck-baseline created |
Training job support-bg-color-cd7417b-230713-054228-tat-truck-baseline completed.Model url: s3://taichi-3d-gaussian-splatting-log/tat-truck-baseline/support-bg-color-cd7417b-230713-054228-tat-truck-baseline/output/model.tar.gz,tensorboard output path: s3://taichi-3d-gaussian-splatting-log/tat-truck-baseline/support-bg-color-cd7417b-230713-054228-tat-truck-baseline/output/output.tar.gz |
|
Training job support-bg-color-cd7417b-230713-054228-tat-truck-baseline final metrics: Latest Metrics
Max Metrics
|
Training job support-bg-color-cd7417b-230713-054144-tat-train-baseline completed.Model url: s3://taichi-3d-gaussian-splatting-log/tat-train-baseline/support-bg-color-cd7417b-230713-054144-tat-train-baseline/output/model.tar.gz,tensorboard output path: s3://taichi-3d-gaussian-splatting-log/tat-train-baseline/support-bg-color-cd7417b-230713-054144-tat-train-baseline/output/output.tar.gz |
|
Training job support-bg-color-cd7417b-230713-054144-tat-train-baseline final metrics: Latest Metrics
Max Metrics
|
|
Does this PR ready for merging (after rebasing)? Anything you plan to work on? @wanmeihuali |
The previous experiment does not show any significant improvement with background color...Actually, the PSNR even dropped a bit... I'm not sure if it will get better after rebasing. Anyway, we will only merge it if it does not hurt the metrics. |
|
I prefer to use "black" background (0, 0, 0) as the default value for training. But at the render time, one can choose to switch between black or white or other custom colors. |
jb-ye
reviewed
Oct 25, 2023
| @@ -1302,6 +1319,10 @@ def forward(self, input_data: GaussianPointCloudRasterisationInput): | |||
| q_pointcloud_camera = input_data.q_pointcloud_camera | |||
| t_pointcloud_camera = input_data.t_pointcloud_camera | |||
| color_max_sh_band = input_data.color_max_sh_band | |||
| background_color = input_data.background_color | |||
| if background_color is None: | |||
| background_color = torch.ones((3, ), dtype=torch.float32, | |||
|
Running experiment on sagemaker with git sha 3ddc747 |
|
Training job support-bg-color-3ddc747-231025-184713-garden created |
|
Running experiment on sagemaker with git sha 3ddc747 |
|
Training job support-bg-color-3ddc747-231025-184731-stump created |
|
Running experiment on sagemaker with git sha 3ddc747 |
|
Training job support-bg-color-3ddc747-231025-184754-tat-train-baseline created |
|
Running experiment on sagemaker with git sha 3ddc747 |
|
Training job support-bg-color-3ddc747-231025-184805-bicycle created |
|
Running experiment on sagemaker with git sha 3ddc747 |
|
Training job support-bg-color-3ddc747-231025-184819-tat-truck-baseline created |
Training job support-bg-color-3ddc747-231025-184731-stump completed.Model url: s3://taichi-3d-gaussian-splatting-log/stump/support-bg-color-3ddc747-231025-184731-stump/output/model.tar.gz,tensorboard output path: s3://taichi-3d-gaussian-splatting-log/stump/support-bg-color-3ddc747-231025-184731-stump/output/output.tar.gz |
|
Training job support-bg-color-3ddc747-231025-184731-stump final metrics: Latest Metrics
Max Metrics
|
Training job support-bg-color-3ddc747-231025-184819-tat-truck-baseline completed.Model url: s3://taichi-3d-gaussian-splatting-log/tat-truck-baseline/support-bg-color-3ddc747-231025-184819-tat-truck-baseline/output/model.tar.gz,tensorboard output path: s3://taichi-3d-gaussian-splatting-log/tat-truck-baseline/support-bg-color-3ddc747-231025-184819-tat-truck-baseline/output/output.tar.gz |
|
Training job support-bg-color-3ddc747-231025-184819-tat-truck-baseline final metrics: Latest Metrics
Max Metrics
|
Training job support-bg-color-3ddc747-231025-184805-bicycle completed.Model url: s3://taichi-3d-gaussian-splatting-log/bicycle/support-bg-color-3ddc747-231025-184805-bicycle/output/model.tar.gz,tensorboard output path: s3://taichi-3d-gaussian-splatting-log/bicycle/support-bg-color-3ddc747-231025-184805-bicycle/output/output.tar.gz |
|
Training job support-bg-color-3ddc747-231025-184805-bicycle final metrics: Latest Metrics
Max Metrics
|
Training job support-bg-color-3ddc747-231025-184754-tat-train-baseline completed.Model url: s3://taichi-3d-gaussian-splatting-log/tat-train-baseline/support-bg-color-3ddc747-231025-184754-tat-train-baseline/output/model.tar.gz,tensorboard output path: s3://taichi-3d-gaussian-splatting-log/tat-train-baseline/support-bg-color-3ddc747-231025-184754-tat-train-baseline/output/output.tar.gz |
|
Training job support-bg-color-3ddc747-231025-184754-tat-train-baseline final metrics: Latest Metrics
Max Metrics
|
Training job support-bg-color-3ddc747-231025-184713-garden completed.Model url: s3://taichi-3d-gaussian-splatting-log/garden/support-bg-color-3ddc747-231025-184713-garden/output/model.tar.gz,tensorboard output path: s3://taichi-3d-gaussian-splatting-log/garden/support-bg-color-3ddc747-231025-184713-garden/output/output.tar.gz |
|
Training job support-bg-color-3ddc747-231025-184713-garden final metrics: Latest Metrics
Max Metrics
|
jb-ye
reviewed
Oct 26, 2023
| @@ -652,6 +660,8 @@ def gaussian_point_rasterisation_backward( | |||
| # \frac{dC}{da_i} = c_i T(i) - \frac{1}{1 - a_i} w_i | |||
| alpha_grad_from_rgb = (color * T_i - w_i / (1. - alpha)) \ | |||
| * pixel_rgb_grad | |||
| alpha_grad_from_rgb -= pixel_rgb_grad * background_color_vector * \ | |||
There was a problem hiding this comment.
Could you provide the formula to calculate the gradient properly? I am a bit confused by the name convention.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.