Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more whitespace checking and fixes (replaces #404) #506

Merged
merged 3 commits into from
Jun 24, 2024

Conversation

JeromeCCP9
Copy link
Collaborator

Whitespace checks in pre-commit.

@JeromeCCP9 JeromeCCP9 changed the title Jimustafa cleanup add more whitespace checking and fixes (replaces #404) Jun 24, 2024
Copy link
Collaborator

@qiaojunfeng qiaojunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🚀

@qiaojunfeng
Copy link
Collaborator

Let's ask Github to auto close & link to the old PR when this PR is merged

close #404

@JeromeCCP9
Copy link
Collaborator Author

(I think that the automatic closure is just for issues, not PRs. I'll do it manually and leave a comment.)

@JeromeCCP9 JeromeCCP9 merged commit 6d433b6 into develop Jun 24, 2024
5 checks passed
@JeromeCCP9 JeromeCCP9 deleted the jimustafa-cleanup branch June 24, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants