Fix broken CRC handling #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
autodidaddict
approved these changes
Apr 9, 2024
autodidaddict
approved these changes
Apr 9, 2024
Signed-off-by: Paolo Barbolini <[email protected]>
paolobarbolini
requested review from
brooksmtownsend and
thomastaylor312
as code owners
brooksmtownsend
approved these changes
Apr 10, 2024
|
Could you make a new release? |
Sure thing, let me double check to see if this needs to be a minor or if we can do a patch and I'll cut it today |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
CRC extraction and verification is broken
Related Issues
None
Release Information
next
Consumer Impact
Big
Testing
None
Unit Test(s)
Added
Acceptance or Integration
None
Manual Verification
None