added: Add Chinese regional text display content #47
Conversation
|
@JinIgarashi Please help assist to see if the relevant content is reasonable |
There was a problem hiding this comment.
@huifer Thank you for the pull request! This translation for Chinese languages is awesome! I just commented few minor things which you can change it before merging to master branch.
README.md
Outdated
| - `zh_Hans_CN` Chinese Simplified | ||
| - `zh_Hant_CN` Chinese Traditional |
There was a problem hiding this comment.
Can we use - for language code instead of _? I think - is generally used to express a language code.
Also, do we need to add CN in the last of code? If there are any differences in translations by regions like China, Hong Kong , Taiwan..., maybe CN is necessary. But we may not need it in this plugin. I think shorter code might be better
lib/export-control.ts
Outdated
| @@ -16,7 +16,7 @@ type Options = { | |||
| Crosshair?: boolean; | |||
| PrintableArea: boolean; | |||
| accessToken?: string; | |||
| Local?: 'de' | 'en' | 'fr' | 'fi' | 'sv' | 'vi'; | |||
| Local?: 'de' | 'en' | 'fr' | 'fi' | 'sv' | 'vi' | 'zh_Hans_CN' | 'zh_Hant_CN'; | |||
There was a problem hiding this comment.
As I commented previously, we can use - and we may not need regional name like CN in a language code.
lib/export-control.ts
Outdated
| case 'zh_Hans_CN': | ||
| return zhHansCN; | ||
| case 'zh_Hant_CN': | ||
| return zhHantCN; |
There was a problem hiding this comment.
This one, too. See my previous comment
lib/local/index.ts
Outdated
| @@ -4,6 +4,8 @@ import finnish from './fi'; | |||
| import german from './de'; | |||
| import swedish from './sv'; | |||
| import vietnam from './vi'; | |||
| import zhHansCN from './zh_Hans_CN'; | |||
| import zhHantCN from './zh_Hant_CN'; | |||
There was a problem hiding this comment.
This one, too. See my previous comment
|
@huifer I am happy to merge this PR to master branch if you can rename files and variables as follows.
Thanks |
|
Let's confirm some final issues now. How would you suggest changing the name for the following content zh_Hans_CN -> zh-Hans |
|
@JinIgarashi Please help assist to see if the relevant content is reasonable |
|
@huifer Thanks for changing. looks great |
Thank you for submitting a pull request!
Description
I've added Chinese regional text information to this project
Type of Pull Request
Verify the followings
mainbranchnpm run lintRefer to CONTRIBUTING.MD for more details.