-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BSM2-P Effluent Metrics w/ Flowsheet Constraints #1503
base: main
Are you sure you want to change the base?
BSM2-P Effluent Metrics w/ Flowsheet Constraints #1503
Conversation
…sHolly/watertap into bsm2_P_metrics_constraints
…sHolly/watertap into bsm2_P_metrics_constraints
@MarcusHolly to make debugging faster by avoiding to run the entire test suite, you can search the |
@lbianchi-lbl I should also note that when I run tests locally on this PR, the same tests that fail here pass on my machine. I would expect the tests to fail locally if the workflow were truly aligned. Is there a possibility that something is out-of-sync? I wonder if it has anything to do with the ipopt-watertap solver and whether that is incorporated in workflows (to start). Although we know this is a troublesome flowsheet, I think we should still expect some alignment between tests that run locally vs. workflows, so I am wondering if this warrants further investigation. |
Summary/Motivation:
An extension of #1492 that adds the effluent violation constraints into the flowsheet
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: