Repair OLIAPI #1512
Open
Repair OLIAPI #1512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…solver iterations; also replacing aeration tank on bsm2-p instead of cstr_injection with flowsheet level vars and constraints
…eys; revisit this change
… BSM2-P solver iterations; also replacing aeration tank on bsm2-p instead of cstr_injection with flowsheet level vars and constraints" This reverts commit bd2caa8.
adam-a-a
requested review from
TimBartholomew,
avdudchenko,
OOAmusat,
luohezhiming,
ElmiraShamlou and
MarcusHolly
…ing files; fix issue related to session dbs file deletion on exit
…credentials used; bring tests back
|
The OLI API CI failures are not entirely reproducible. @adam-a-a will reach out to OLI to investigate this. |
lbianchi-lbl
added
Priority:Normal
… to troubleshoot errors after switch to sequential test deployment
…hange would break them again to identify what the solution was
…d bring back a change that I ultimately want to remove but think might have been part of prob
…erted for oliapi_instance, along with point to last session dbs file in test_flash; now will set refresh=True on oliapi_instance in conftest
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1512 +/- ##
==========================================
+ Coverage 93.56% 94.26% +0.70%
==========================================
Files 281 283 +2
Lines 30111 30920 +809
==========================================
+ Hits 28173 29148 +975
+ Misses 1938 1772 -166 ☔ View full report in Codecov by Sentry. |
MarcusHolly
reviewed
Nov 4, 2024
…sponse when shifting to alternate version of OLI used for NAWI
MarcusHolly
approved these changes
Nov 18, 2024
Comment on lines
115
to
117
| if self.interactive_mode: | ||
| msg = msg + "Enter [y]/n to proceed." | ||
| return input(msg) |
There was a problem hiding this comment.
Does the interactive mode functionality work in Jupyter? It doesn't seem to be the case, and, if so, perhaps it should be set to False in the tutorial
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes/Resolves:
OLI API stopped working.
Summary/Motivation:
Users were no longer able to get back OLI calculations. We were able to log in, generate a DBS file, and that was about it. The issue came down to an additional forward slash used in one of the URLs, which previously worked.
EDIT: Subsequently, CI checks were failing as well, while local tests were passing. This PR also addresses those issues.
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: