Update Dye Desal Flowsheet Parameters #1528
Open
+154
−96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| model.fs.unit.properties_byproduct[0].conc_mass_comp["tds"] | ||
| ) | ||
| assert pytest.approx(14.237023, rel=1e-5) == value( | ||
| assert pytest.approx(23.710346, rel=1e-5) == value( |
There was a problem hiding this comment.
This seems a large difference, was this expected?
There was a problem hiding this comment.
Yea, I think a large change should be expected since the tds removal frac was changed from 0.212 to 0.145
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes/Resolves:
Builds off #1485 to update various parameters values based on feedback.
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: