Replace Window id's with HashMap #37
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lock is not need anymore this is controlled by iced_layershell itself |
|
I have not got the meaning of this pr |
|
We should not use HashMap for these windows, because they are singleton window, should only exist one, and the singleton is already controlled by iced_layershell |
|
just update the ui.. you should not change the logic of hidden_id, it is not the part of yours, and here it should not use hashmap I think |
Decodetalkers
requested changes
Dec 5, 2024
|
Had thought of having a refactor for managing the window id's by using a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.