Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix WQL documentation link #5889

Merged
merged 2 commits into from
Sep 13, 2023
Merged

Fix WQL documentation link #5889

merged 2 commits into from
Sep 13, 2023

Conversation

Desvelao
Copy link
Member

@Desvelao Desvelao commented Sep 13, 2023 •
edited
Loading

Description

This pull request fixes the link to the WQL documentation. It redirects to the official documentation instead of repository documenation.

Issues Resolved

#5867

Evidence

image

Test

Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable

UI

Test Chrome Firefox Safari
Ensure the WQL documentation link is pointing to the official documentation and the link would be valid. ⚫ ⚫ ⚫

Details

⚫ Ensure the WQL documentation link is pointing to the official documentation and the link would be valid.

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@Desvelao Desvelao requested a review from a team as a code owner September 13, 2023 08:00
@Desvelao Desvelao self-assigned this Sep 13, 2023
@Desvelao Desvelao linked an issue Sep 13, 2023 that may be closed by this pull request
The documentation link for WQL is not working #5867
Closed
@github-actions
Copy link
Contributor

Code coverage (Jest) % values
Statements 11.47% ( 3959 / 34493 )
Branches 7.57% ( 1775 / 23426 )
Functions 10.86% ( 896 / 8248 )
Lines 11.66% ( 3847 / 32988 )

@JuanGarriuz JuanGarriuz self-requested a review September 13, 2023 11:18
@JuanGarriuz
Copy link
Member

Test

Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable

UI

Test Chrome Firefox Safari
Ensure the WQL documentation link is pointing to the official documentation and the link would be valid. 🟢 ⚫ ⚫

Details

🟢 Ensure the WQL documentation link is pointing to the official documentation and the link would be valid.

image
image

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

JuanGarriuz
JuanGarriuz approved these changes Sep 13, 2023
View reviewed changes
Copy link
Member

@JuanGarriuz JuanGarriuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

Tostti
Tostti approved these changes Sep 13, 2023
View reviewed changes
Copy link
Member

@Tostti Tostti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
TEST:✔️
CR:✔️

LGTM

@Tostti Tostti merged commit d24e037 into 4.6.0 Sep 13, 2023
2 checks passed
@Tostti Tostti deleted the enhancement/5867-replace-link-wql-documentation branch September 13, 2023 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JuanGarriuz JuanGarriuz JuanGarriuz approved these changes

@Tostti Tostti Tostti approved these changes

Assignees

@Desvelao Desvelao

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The documentation link for WQL is not working
3 participants
@Desvelao @JuanGarriuz @Tostti