Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine UI and Remove wazuh prefix #6155

Merged
merged 33 commits into from
Apr 2, 2024
Merged

Refine UI and Remove wazuh prefix #6155

merged 33 commits into from
Apr 2, 2024

Conversation

JuanGarriuz
Copy link
Member

@JuanGarriuz JuanGarriuz commented Nov 27, 2023 •
edited
Loading

Description

This PR involves removing unmaintained visualizations and improving the titles and references across the application.

Issues Resolved

#6128

Evidence

About

image

Logs

image

Health Check

image

Deploy New Agent

image

Endpoint Summary chart remove

image
image
image

Test

  • Check that the Endpoints Summary does not display the evolution chart and ensure that the status and details adjust correctly within the space.
  • Verify that the Wazuh prefix has been organically and appropriately removed where necessary.

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@JuanGarriuz JuanGarriuz linked an issue Nov 27, 2023 that may be closed by this pull request
Refine UI and remove wazuh prefix #6128
Closed
@JuanGarriuz JuanGarriuz self-assigned this Nov 29, 2023
@JuanGarriuz JuanGarriuz marked this pull request as ready for review November 29, 2023 11:19
@JuanGarriuz JuanGarriuz requested a review from a team as a code owner November 29, 2023 11:19
@Desvelao
Copy link
Member

Desvelao commented Dec 4, 2023

thought: the usage of generic terms such as server or API is not clear to me. There are 3 servers in a stack (manager, dashboard and indexer) that have APIs.

@JuanGarriuz JuanGarriuz changed the base branch from master to 4.9.0 February 13, 2024 09:25
Tostti
Tostti reviewed Feb 15, 2024
View reviewed changes
Copy link
Member

@Tostti Tostti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test

image
image
image
image
image
image

@Desvelao
Copy link
Member

Reviewing the source code, I found some references that we could consider to change:

  • PLUGIN_PLATFORM_NAME constant
  • WAZUH_INDEXER_NAME constant
  • Wazuh not ready yet reference related to server/agent configuration

files:

  • plugins/main/public/components/add-modules-data/guides/audit.js
  • plugins/main/public/components/add-modules-data/guides/fim.js
  • plugins/main/public/controllers/management/components/management/configuration/github/github.tsx
  • plugins/main/public/controllers/management/components/management/configuration/google-cloud-pub-sub/google-cloud-pub-sub.js
  • plugins/main/public/controllers/management/components/management/configuration/office365/constants.tsx
  • plugins/main/public/controllers/management/components/management/configuration/utils/wz-fetch.js
  • plugins/main/public/controllers/settings/settings.js
  • plugins/main/public/services/check-daemon-status.js
  • plugins/main/server/controllers/wazuh-api.ts
  • plugins/wazuh-core/common/constants.ts

@JuanGarriuz JuanGarriuz requested review from Tostti and Desvelao March 26, 2024 08:19
@Desvelao
Copy link
Member

Test

image
image
image
image
image

Desvelao
Desvelao approved these changes Mar 27, 2024
View reviewed changes
Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 2, 2024

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 2, 2024

Wazuh Core plugin code coverage (Jest) test % values
Statements 28.94% ( 286 / 988 )
Branches 26.22% ( 107 / 408 )
Functions 26.87% ( 86 / 320 )
Lines 28.68% ( 278 / 969 )

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 2, 2024

Main plugin code coverage (Jest) test % values
Statements 12.12% ( 4210 / 34729 )
Branches 7.8% ( 1776 / 22760 )
Functions 10.77% ( 888 / 8244 )
Lines 12.31% ( 4101 / 33295 )

@asteriscos
Copy link
Member

asteriscos commented Apr 2, 2024 •
edited
Loading

Endpoint summary

image

Logs

image

About

image

Deploy agent

screencapture-localhost-5601-app-endpoints-summary-2024-04-02-15_04_52

Health check

screencapture-localhost-5601-app-app-settings-2024-04-02-15_10_02

@asteriscos asteriscos merged commit fc92c44 into 4.9.0 Apr 2, 2024
4 checks passed
@asteriscos asteriscos deleted the feat/6128-refine-ui-remove-wazuh-prefix branch April 2, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Desvelao Desvelao Desvelao approved these changes

@asteriscos asteriscos asteriscos approved these changes

@Tostti Tostti Awaiting requested review from Tostti

Assignees

@JuanGarriuz JuanGarriuz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refine UI and remove wazuh prefix
4 participants
@JuanGarriuz @Desvelao @asteriscos @Tostti