-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create unique agents preview react component #6196
Merged
lucianogorza
merged 21 commits into
enhancement/6129-new-endpoint-management-plugin
from
enhancement/6150/create-unique-agents-preview-react-component
Dec 15, 2023
Merged
Create unique agents preview react component #6196
lucianogorza
merged 21 commits into
enhancement/6129-new-endpoint-management-plugin
from
enhancement/6150/create-unique-agents-preview-react-component
Dec 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
...lic/components/endpoints-summary/register-agent/containers/register-agent/register-agent.tsx
Outdated
Show resolved
Hide resolved
...lic/components/endpoints-summary/register-agent/containers/register-agent/register-agent.tsx
Outdated
Show resolved
Hide resolved
|
TestLegend: Guide to create read only user
|
lucianogorza
force-pushed
the
enhancement/6150/create-unique-agents-preview-react-component
branch
from
December 13, 2023 16:37
7801d5b
to
d163ae1
Compare
JuanGarriuz
approved these changes
Dec 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
.../public/components/endpoints-summary/register-agent/services/register-agent-services.test.ts
Outdated
Show resolved
Hide resolved
* Create new plugin wazuh-endpoints * Delete import * Add github action to run plugin test * Remove github action to run plugin test
lucianogorza
force-pushed
the
enhancement/6150/create-unique-agents-preview-react-component
branch
from
December 15, 2023 12:29
408cb34
to
f4f7a31
Compare
lucianogorza
force-pushed
the
enhancement/6129-new-endpoint-management-plugin
branch
from
December 15, 2023 12:33
4357c94
to
67c3e40
Compare
|
|
|
yenienserrano
approved these changes
Dec 15, 2023
lucianogorza
merged commit Dec 15, 2023
1fcc5a3
into
enhancement/6129-new-endpoint-management-plugin
4 checks passed
lucianogorza
deleted the
enhancement/6150/create-unique-agents-preview-react-component
branch
December 15, 2023 13:58
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace the rendering of several agent preview components with a single React component on the angular template context.
Additionally, add a new page when there are no registered agents instead of redirecting to the page to register agents.
Issues Resolved
#6150
Evidence
With registered Agents: Go to Endpoints Summary -> Click
Deploy new agent
With no registered Agents: Go to Endpoints Summary -> Click
Deploy new agent
With no registered Agents: Go to Overview -> Click
Add agent
Generate commands for Linux
Generate commands for Windows
Generate commands for Mac
With no registered Agents and read only user: Go to
Overview
With no registered Agents and read only user: Go to E
ndpoints Summary
With no registered Agents and read only user: Go to
/app/endpoints-summary#/agents-preview/deploy
Test
Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable
Guide to create read only user
https://documentation.wazuh.com/current/user-manual/user-administration/rbac.html#creating-and-setting-a-wazuh-read-only-user
Deploy new agent
Deploy new agent
Add agent
Overview
ndpoints Summary
/app/endpoints-summary#/agents-preview/deploy
Check List
yarn test:jest