Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new discover component and children components #6205

Merged
merged 12 commits into from
Dec 14, 2023
Merged

Add new discover component and children components #6205

merged 12 commits into from
Dec 14, 2023

Conversation

Machi3mfl
Copy link
Member

@Machi3mfl Machi3mfl commented Dec 12, 2023 •
edited
Loading

Description

Add all components necessary to compose the new discover component and make it available for reusability

Testing

This PR only makes available discover components in public/components/common folder.

  • search-bar
  • data-grid
  • doc-viewer
  • wazuh-discover

Closes #6197

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@Machi3mfl Machi3mfl requested a review from a team as a code owner December 12, 2023 12:38
@Machi3mfl Machi3mfl mentioned this pull request Dec 12, 2023
Closed
6 tasks
@Machi3mfl Machi3mfl changed the title Add new discover components and children components Add new discover component and children components Dec 12, 2023
@lucianogorza lucianogorza self-requested a review December 12, 2023 15:21
lucianogorza
lucianogorza reviewed Dec 12, 2023
View reviewed changes
Copy link
Contributor

@lucianogorza lucianogorza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The PR is pointing to master branch
  • The file names use snake case and we use kebab case.

plugins/main/public/components/common/doc_viewer/doc_viewer.tsx Outdated Show resolved Hide resolved
plugins/main/public/components/common/doc_viewer/doc_viewer.tsx Outdated Show resolved Hide resolved
plugins/main/public/components/common/hooks/data_grid/data_grid_service.ts Outdated Show resolved Hide resolved
@Machi3mfl
Copy link
Member Author

  • The PR is pointing to master branch
  • The file names use snake case and we use kebab case.

Yes, The PR is pointing to master because is a 4.9.0 feature
As to the naming convention, I used the OpenSearch naming convention that uses snake case.

@chantal-kelm chantal-kelm self-requested a review December 13, 2023 13:56
chantal-kelm
chantal-kelm reviewed Dec 13, 2023
View reviewed changes
plugins/main/public/components/common/hooks/search_bar/use_search_bar.tsx Outdated Show resolved Hide resolved
plugins/main/public/components/common/wazuh_discover/wz_discover.tsx Outdated Show resolved Hide resolved
plugins/main/public/components/common/wazuh_discover/wz_discover.tsx Outdated Show resolved Hide resolved
plugins/main/public/components/common/wazuh_discover/wz_discover.tsx Outdated Show resolved Hide resolved
plugins/main/public/components/common/wazuh_discover/wz_discover.tsx Outdated Show resolved Hide resolved
plugins/main/public/components/common/wazuh_discover/wz_discover.tsx Outdated Show resolved Hide resolved
plugins/main/public/components/common/wazuh_discover/config/chart.ts Outdated Show resolved Hide resolved
plugins/main/public/components/common/hooks/data_grid/data_grid_service.ts Outdated Show resolved Hide resolved
@Machi3mfl
Copy link
Member Author

Machi3mfl commented Dec 14, 2023 •
edited
Loading

@lucianogorza, Replaced file name convention to kebab-case in 3784f94 commit

lucianogorza
lucianogorza approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@lucianogorza lucianogorza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 21.38% ( 185 / 865 )
Branches 18.07% ( 79 / 437 )
Functions 14.22% ( 36 / 253 )
Lines 21.61% ( 182 / 842 )

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.95% ( 167 / 217 )
Branches 54.63% ( 53 / 97 )
Functions 60.86% ( 28 / 46 )
Lines 76.95% ( 167 / 217 )

@github-actions GitHub Actions
Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 11.88% ( 4221 / 35527 )
Branches 8.12% ( 1936 / 23821 )
Functions 11.24% ( 955 / 8492 )
Lines 12.06% ( 4104 / 34020 )

@Machi3mfl Machi3mfl mentioned this pull request Dec 14, 2023
Closed
4 tasks
@Machi3mfl Machi3mfl merged commit 4b967e2 into master Dec 14, 2023
4 checks passed
@Machi3mfl Machi3mfl deleted the feat/6197-new-discover-components branch December 14, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucianogorza lucianogorza lucianogorza approved these changes

@chantal-kelm chantal-kelm chantal-kelm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Remove discover] Add all the necessary components to compose the new discover
3 participants
@Machi3mfl @chantal-kelm @lucianogorza