Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reports path in toast #6226

Merged
merged 3 commits into from
Dec 18, 2023
Merged

Fix reports path in toast #6226

merged 3 commits into from
Dec 18, 2023

Conversation

Tostti
Copy link
Member

@Tostti Tostti commented Dec 15, 2023

Description

After the redesign of the application, the path of generated reports changed. This PR changes the toast that notifies the user where to find the reports to show the current path.

Issues Resolved

#6215

Evidence

image

Test

  • Navigate to IT Hygiene
  • Select an agent
  • Go to Configuration option
  • Select Generate Report
  • Confirm that the toast shows the correct path

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@Tostti Tostti marked this pull request as ready for review December 15, 2023 15:01
@Tostti Tostti requested a review from a team as a code owner December 15, 2023 15:01
yenienserrano
yenienserrano previously approved these changes Dec 15, 2023
View reviewed changes
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

image

@lucianogorza lucianogorza self-requested a review December 15, 2023 18:50
lucianogorza
lucianogorza previously approved these changes Dec 15, 2023
View reviewed changes
Copy link
Contributor

@lucianogorza lucianogorza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

image

@lucianogorza
Copy link
Contributor

The only doubt remaining for me is whether the entry in the changelog is necessary, given that it's a fix for a release that hasn't been published yet.

@Tostti Tostti dismissed stale reviews from lucianogorza and yenienserrano via 6f45e29 December 18, 2023 15:58
@github-actions GitHub Actions
Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.68% ( 171 / 223 )
Branches 57.57% ( 57 / 99 )
Functions 61.7% ( 29 / 47 )
Lines 76.68% ( 171 / 223 )

lucianogorza
lucianogorza approved these changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@lucianogorza lucianogorza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 21.47% ( 186 / 866 )
Branches 18.07% ( 79 / 437 )
Functions 14.22% ( 36 / 253 )
Lines 21.7% ( 183 / 843 )

@github-actions GitHub Actions
Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 12.08% ( 4159 / 34423 )
Branches 8.17% ( 1889 / 23118 )
Functions 11.53% ( 943 / 8173 )
Lines 12.25% ( 4046 / 33014 )

@Tostti Tostti merged commit c046cc5 into 4.8.0 Dec 18, 2023
4 checks passed
@Tostti Tostti deleted the 6215-fix-reports-path-in-toast branch December 18, 2023 16:05
@Tostti Tostti linked an issue Dec 18, 2023 that may be closed by this pull request
Notification points to a non-existing path #6215
Closed
yenienserrano added a commit that referenced this pull request Apr 18, 2024
@yenienserrano
Revert "Develop logic of a new index for the fim module (#6226)"
c1e40d2 
This reverts commit 72289d5.
Tostti pushed a commit that referenced this pull request Apr 19, 2024
@yenienserrano
Revert "Develop logic of a new index for the fim module (#6226)" (#6601)
723039a 
This reverts commit 72289d5.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucianogorza lucianogorza lucianogorza approved these changes

@yenienserrano yenienserrano yenienserrano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Notification points to a non-existing path
3 participants
@Tostti @lucianogorza @yenienserrano