Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop logic of a new index for the fim module #6227

Merged

Conversation

chantal-kelm
Copy link
Member

@chantal-kelm chantal-kelm commented Dec 15, 2023

Description

Develop logic of a new index for the fim module

Issues Resolved

#6210

Evidence

image image image

Test

  • Verify that when you load the health check you get the index pattern warning of fim

  • Verify that when you go to the dashboard tab it does not show visualisations as the index pattern is not available.

  • Verify that the inventory tab does not load information.

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@chantal-kelm chantal-kelm self-assigned this Dec 15, 2023
@chantal-kelm chantal-kelm requested a review from a team as a code owner December 15, 2023 15:49
This was linked to issues Dec 15, 2023
@chantal-kelm chantal-kelm removed a link to an issue Dec 15, 2023
7 tasks
@chantal-kelm chantal-kelm marked this pull request as draft December 15, 2023 16:33
@chantal-kelm chantal-kelm marked this pull request as ready for review December 15, 2023 17:44
Copy link
Member

@Tostti Tostti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#Test ✅
image

image

image

#CR ✅

LGTM

Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 21.33% ( 185 / 867 )
Branches 18.07% ( 79 / 437 )
Functions 14.11% ( 36 / 255 )
Lines 21.56% ( 182 / 844 )

Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.95% ( 167 / 217 )
Branches 54.63% ( 53 / 97 )
Functions 60.86% ( 28 / 46 )
Lines 76.95% ( 167 / 217 )

Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 11.55% ( 4052 / 35070 )
Branches 7.6% ( 1764 / 23200 )
Functions 11.02% ( 922 / 8362 )
Lines 11.73% ( 3940 / 33570 )

@yenienserrano yenienserrano self-requested a review December 20, 2023 11:17
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:

image

image

image

@asteriscos asteriscos merged commit 72289d5 into master Dec 21, 2023
4 checks passed
@asteriscos asteriscos deleted the feat/6210-Develop-logic-of-a-new-index-for-the-fim-module branch December 21, 2023 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Developing logic for new index
4 participants