Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Server APIs table updates status column #6256

Merged
merged 5 commits into from
Jan 2, 2024
Merged

Fix Server APIs table updates status column #6256

merged 5 commits into from
Jan 2, 2024

Conversation

lucianogorza
Copy link
Contributor

@lucianogorza lucianogorza commented Jan 2, 2024 •
edited
Loading

Description

This PR fixes Update status column from Server API table when new manager is added and the user is already logged in.

Issues Resolved

#6255

Evidence

image

Test

  1. Log in.
  2. Add a new manager
  3. Go to the Indexer/Server management -> Server APIs

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@lucianogorza lucianogorza self-assigned this Jan 2, 2024
@lucianogorza lucianogorza linked an issue Jan 2, 2024 that may be closed by this pull request
Server APIs table doesn't show update status when new manager is added #6255
Closed
@lucianogorza lucianogorza marked this pull request as ready for review January 2, 2024 15:15
@lucianogorza lucianogorza requested a review from a team as a code owner January 2, 2024 15:15
yenienserrano
yenienserrano previously approved these changes Jan 2, 2024
View reviewed changes
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

image

image

asteriscos
asteriscos previously approved these changes Jan 2, 2024
View reviewed changes
Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✔️
Test: ✔️

image

@lucianogorza lucianogorza dismissed stale reviews from asteriscos and yenienserrano via 8051e70 January 2, 2024 16:04
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 2, 2024

Wazuh Core plugin code coverage (Jest) test % values
Statements 21.42% ( 186 / 868 )
Branches 17.99% ( 79 / 439 )
Functions 14.22% ( 36 / 253 )
Lines 21.65% ( 183 / 845 )

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 2, 2024

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.68% ( 171 / 223 )
Branches 57.57% ( 57 / 99 )
Functions 61.7% ( 29 / 47 )
Lines 76.68% ( 171 / 223 )

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 2, 2024

Main plugin code coverage (Jest) test % values
Statements 12.08% ( 4160 / 34435 )
Branches 8.18% ( 1893 / 23135 )
Functions 11.54% ( 944 / 8177 )
Lines 12.25% ( 4047 / 33026 )

@asteriscos asteriscos merged commit 50ae4e9 into 4.8.0 Jan 2, 2024
4 checks passed
@asteriscos asteriscos deleted the fix/6255-server-apis-table-doesnt-show-update-status branch January 2, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yenienserrano yenienserrano yenienserrano approved these changes

@asteriscos asteriscos asteriscos approved these changes

Assignees

@lucianogorza lucianogorza

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Server APIs table doesn't show update status when new manager is added
3 participants
@lucianogorza @asteriscos @yenienserrano