Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Inventory table from vulnerability dashboard tab and change filter titles #6260

Merged

Conversation

jbiset
Copy link
Member

@jbiset jbiset commented Jan 3, 2024

Description

This pull request removes the inventory table from the vulnerability dashboard tab
Filter titles are also renamed to more meaningful names:

  • Top 5 package names
  • Top 5 operating systems
  • Top 5 agents
  • Top 5 vulnerabilities

Issues Resolved

#6259

Evidence

Evidence_1

Test

Note

Use the script on scripts/vulnerabilities-events-injector/dataInjectScript.py to insert vulnerability index and data index.

Steps

  • Go to Vulnerability detection on Threat intelligence
  • Check that the table below is no longer in the dashboard tab
  • Check the new filter titles.

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@jbiset jbiset self-assigned this Jan 3, 2024
@jbiset jbiset requested a review from a team as a code owner January 3, 2024 17:35
@jbiset jbiset linked an issue Jan 3, 2024 that may be closed by this pull request
Copy link
Contributor

github-actions bot commented Jan 3, 2024

Wazuh Core plugin code coverage (Jest) test % values
Statements 21.42% ( 186 / 868 )
Branches 17.99% ( 79 / 439 )
Functions 14.22% ( 36 / 253 )
Lines 21.65% ( 183 / 845 )

Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✔️
Test: ✔️

image

Copy link
Contributor

github-actions bot commented Jan 3, 2024

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.68% ( 171 / 223 )
Branches 57.57% ( 57 / 99 )
Functions 61.7% ( 29 / 47 )
Lines 76.68% ( 171 / 223 )

Copy link
Contributor

github-actions bot commented Jan 3, 2024

Main plugin code coverage (Jest) test % values
Statements 12.08% ( 4160 / 34433 )
Branches 8.18% ( 1893 / 23135 )
Functions 11.54% ( 944 / 8176 )
Lines 12.25% ( 4047 / 33024 )

@lucianogorza lucianogorza self-requested a review January 3, 2024 18:20
Copy link
Contributor

@lucianogorza lucianogorza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR ✔️
Test ✔️
image

@asteriscos asteriscos merged commit db97880 into 4.8.0 Jan 3, 2024
4 checks passed
@asteriscos asteriscos deleted the fix/6259-remove-table-from-vulnerability-dashboard-tab branch January 3, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove table from vulnerability dashboard tab
3 participants