Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace discover Vulnerability #6275

Merged
merged 8 commits into from
Jan 10, 2024
Merged

Replace discover Vulnerability #6275

merged 8 commits into from
Jan 10, 2024

Conversation

yenienserrano
Copy link
Member

@yenienserrano yenienserrano commented Jan 8, 2024 •
edited
Loading

Description

This PR, replaces the events tab on the Vulnerability module

Issues Resolved

Evidence

image

Tests

Search bar

Test Chrome Firefox Safari
Apply filters using search bar input ⚫ ⚫ ⚫
Apply filters using the search bar add filter feature ⚫ ⚫ ⚫
Apply filters using the date picker ⚫ ⚫ ⚫
Apply filters with no results (Check the No results match your search criteria message) ⚫ ⚫ ⚫
Use the saved queries feature (Check saved queries CRUD) ⚫ ⚫ ⚫
  • Apply filters using search bar input
  • Apply filters using the search bar add filter feature
  • Apply filters using the date picker
  • Apply filters with no results (Check the No results match your search criteria message)
  • Use the saved queries feature (Check saved queries CRUD)

Histogram chart

Test Chrome Firefox Safari
Check histogram chart hits consistency ⚫ ⚫ ⚫
Use chart options (three points: maximize, minimize, inspect) ⚫ ⚫ ⚫
  • Check histogram chart hits consistency
  • Use chart options (three points: maximize, minimize, inspect)

Data grid

Test Chrome Firefox Safari
Check all table header features (sort, show/hide columns, density, etc) ⚫ ⚫ ⚫
Check table pagination and rows per page ⚫ ⚫ ⚫
Check document detail flyout ⚫ ⚫ ⚫
  • Check all table header features (sort, show/hide columns, density, etc)
  • Check table pagination and rows per page
  • Check document detail flyout

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@yenienserrano yenienserrano requested a review from a team as a code owner January 8, 2024 17:09
@yenienserrano yenienserrano changed the title Replace discover Replace discover Vulnerability Jan 8, 2024
@yenienserrano yenienserrano linked an issue Jan 8, 2024 that may be closed by this pull request
[Remove discover] Replace discover on vulnerability detection module #6273
Closed
1 task
@yenienserrano yenienserrano self-assigned this Jan 8, 2024
@Machi3mfl
Copy link
Member

Machi3mfl commented Jan 8, 2024 •
edited
Loading

Tests

Search bar

Test Chrome Firefox Safari
Apply filters using search bar input 🟢 ⚫ ⚫
Apply filters using the search bar add filter feature 🟢 ⚫ ⚫
Apply filters using the date picker 🟢 ⚫ ⚫
Apply filters with no results (Check the No results match your search criteria message) 🟢 ⚫ ⚫
Use the saved queries feature (Check saved queries CRUD) 🟢 ⚫ ⚫
  • Apply filters using search bar input
Screen.Recording.2024-01-08.at.20.07.11.mov
  • Apply filters using the search bar add filter feature
Screen.Recording.2024-01-08.at.20.07.50.mov
  • Apply filters using the date picker
Screen.Recording.2024-01-08.at.20.08.38.mov
  • Apply filters with no results (Check the No results match your search criteria message)
Screen.Recording.2024-01-08.at.20.08.38.mov
  • Use the saved queries feature (Check saved queries CRUD)
Screen.Recording.2024-01-08.at.20.09.11.mov

Histogram chart

Test Chrome Firefox Safari
Check histogram chart hits consistency 🟢 ⚫ ⚫
Use chart options (three points: maximize, minimize, inspect) 🟢 ⚫ ⚫
  • Check histogram chart hits consistency
Screen.Recording.2024-01-08.at.20.11.17.mov
  • Use chart options (three points: maximize, minimize, inspect)
Screen.Recording.2024-01-08.at.20.12.13.mov

Data grid

Test Chrome Firefox Safari
Check all table header features (sort, show/hide columns, density, etc) 🟢 ⚫ ⚫
Check table pagination and rows per page 🟢 ⚫ ⚫
Check document detail flyout 🟢 ⚫ ⚫
  • Check all table header features (sort, show/hide columns, density, etc)
Screen.Recording.2024-01-08.at.20.13.03.mov
  • Check table pagination and rows per page
Screen.Recording.2024-01-08.at.20.14.15.mov
  • Check document detail flyout
Screen.Recording.2024-01-08.at.20.14.57.mov

@Machi3mfl Machi3mfl self-requested a review January 8, 2024 17:41
@jbiset jbiset self-requested a review January 10, 2024 11:44
jbiset
jbiset reviewed Jan 10, 2024
View reviewed changes
Copy link
Member

@jbiset jbiset left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Evidence

image

Tests

Search bar

Test Chrome Firefox Safari
Apply filters using search bar input 🟢 🟢 ⚫
Apply filters using the search bar add filter feature 🟢 🟢 ⚫
Apply filters using the date picker 🟢 🟢 ⚫
Apply filters with no results (Check the No results match your search criteria message) 🟢 🟢 ⚫
Use the saved queries feature (Check saved queries CRUD) 🟢 🟢 ⚫
  • Apply filters using search bar input 🟢
### Chrome ![image](https://github.com/wazuh/wazuh-dashboard-plugins/assets/43619595/fc84018e-a9b4-4ca4-b220-fc31ae3dbeee)

Firefox

image

  • Apply filters using the search bar add filter feature 🟢
### Chrome ![image](https://github.com/wazuh/wazuh-dashboard-plugins/assets/43619595/f77b6a06-ff81-4d23-a988-48455cf8f718)

Firefox

image

  • Apply filters using the date picker 🟢
### Chrome ![image](https://github.com/wazuh/wazuh-dashboard-plugins/assets/43619595/f3609c27-1b9a-4ab6-8b2c-47ebd0d76781)

Firefox

image

  • Apply filters with no results (Check the No results match your search criteria message) 🟢
### Chrome ![image](https://github.com/wazuh/wazuh-dashboard-plugins/assets/43619595/100d32d7-df87-4f89-8e14-7e5716c3c914)

Firefox

image

  • Use the saved queries feature (Check saved queries CRUD) 🟢
### Chrome [Evidence_saved_query_chrome.webm](https://github.com/wazuh/wazuh-dashboard-plugins/assets/43619595/cca17acd-9c68-4673-9b6a-bf60350638d8)

Firefox

Evidence_saved_query_firefox.webm

Histogram chart

Test Chrome Firefox Safari
Check histogram chart hits consistency 🟢 🟢 ⚫
Use chart options (three points: maximize, minimize, inspect) 🟢 🟢 ⚫
  • Check histogram chart hits consistency 🟢
### Chrome [Evidence_histogram_consistency_chrome.webm](https://github.com/wazuh/wazuh-dashboard-plugins/assets/43619595/df02d033-c56a-40ae-8632-5a20f627bd0a)

Firefox

Evidence_histogram_consistency_firefox.webm
  • Use chart options (three points: maximize, minimize, inspect) 🟢
### Chrome [Evidence_histogram_chart_options_chrome.webm](https://github.com/wazuh/wazuh-dashboard-plugins/assets/43619595/549ab68c-98ca-42a3-ae7f-6ad06ec9fbb6)

Firefox

Evidence_histogram_chart_options_firefox.webm

Data grid

Test Chrome Firefox Safari
Check all table header features (sort, show/hide columns, density, etc) 🟢 🟢 ⚫
Check table pagination and rows per page 🟢 🟢 ⚫
Check document detail flyout 🟢 🟢 ⚫
  • Check all table header features (sort, show/hide columns, density, etc) 🟢
### Chrome [Evidence_grid_table_features_chrome.webm](https://github.com/wazuh/wazuh-dashboard-plugins/assets/43619595/0707d3d8-8f61-47c4-9210-44155c90dfdb)

Firefox

Evidence_grid_table_features_firefox.webm
  • Check table pagination and rows per page 🟢
### Chrome [Evidence_grid_table_pagination_chrome.webm](https://github.com/wazuh/wazuh-dashboard-plugins/assets/43619595/75b87d7b-5344-478b-98b7-5589dd38437d)

Firefox

Evidence_grid_table_pagination_firefox.webm
  • Check document detail flyout 🟢
### Chrome [Evidence_grid_table_document_detail_flyout_chrome.webm](https://github.com/wazuh/wazuh-dashboard-plugins/assets/43619595/cf975843-a09e-403c-a7a0-eb30e9ef9de0)

Firefox

Evidence_grid_table_document_detail_flyout_firefox.webm

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 22.02% ( 176 / 799 )
Branches 19.55% ( 79 / 404 )
Functions 14.63% ( 36 / 246 )
Lines 22.23% ( 173 / 778 )

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.33% ( 171 / 224 )
Branches 57.57% ( 57 / 99 )
Functions 61.7% ( 29 / 47 )
Lines 76.33% ( 171 / 224 )

@github-actions GitHub Actions
Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 11.41% ( 3918 / 34337 )
Branches 7.55% ( 1715 / 22687 )
Functions 11% ( 903 / 8205 )
Lines 11.58% ( 3807 / 32875 )

@asteriscos asteriscos merged commit c42fce2 into master Jan 10, 2024
4 checks passed
@asteriscos asteriscos deleted the feat/6273-replace-discover-vulnerabilities branch January 10, 2024 18:11
@asteriscos asteriscos mentioned this pull request Aug 21, 2024
Closed
74 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbiset jbiset jbiset approved these changes

@Machi3mfl Machi3mfl Machi3mfl approved these changes

Assignees

@yenienserrano yenienserrano

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Remove discover] Replace discover on vulnerability detection module
4 participants
@yenienserrano @Machi3mfl @jbiset @asteriscos