-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace discover Configuration assessment #6285
Merged
asteriscos
merged 2 commits into
master
from
feat/6276-replace-discover-configuration-assessment
Jan 9, 2024
Merged
Replace discover Configuration assessment #6285
asteriscos
merged 2 commits into
master
from
feat/6276-replace-discover-configuration-assessment
Jan 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
|
|
jbiset
reviewed
Jan 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR: 🟢
Tests
Configuration Assessment screen
Search bar
Test | Chrome | Firefox | Safari |
---|---|---|---|
Apply filters using search bar input | 🟢 | 🟢 | ⚫ |
Apply filters using the search bar add filter feature |
🟢 | 🟢 | ⚫ |
Apply filters using the date picker | 🟢 | 🟢 | ⚫ |
Apply filters with no results (Check the No results match your search criteria message) |
🟢 | 🟢 | ⚫ |
Use the saved queries feature (Check saved queries CRUD) |
🟢 | 🟢 | ⚫ |
- Apply filters using search bar input
- Apply filters using the search bar
add filter
feature
- Apply filters using the date picker
- Apply filters with no results (Check the
No results match your search criteria
message)
- Use the
saved queries
feature (Check saved queries CRUD)
Chrome 🟢
Evidence_saved_query_chrome.webm
Firefox 🟢
Evidence_saved_query_firefox.webm
Histogram chart
Test | Chrome | Firefox | Safari |
---|---|---|---|
Check histogram chart hits consistency | 🟢 | 🟢 | ⚫ |
Use chart options (three points: maximize, minimize, inspect) | 🟢 | 🟢 | ⚫ |
- Check histogram chart hits consistency
Chrome 🟢
Evidence_histogram_chart_consistency_chrome.webm
Firefox 🟢
Evidence_histogram_chart_consistency_firefox.webm
- Use chart options (three points: maximize, minimize, inspect)
Chrome 🟢
Evidence_histogram_options_chrome.webm
Firefox 🟢
Evidence_histogram_options_firefox.webm
Data grid
Test | Chrome | Firefox | Safari |
---|---|---|---|
Check all table header features (sort, show/hide columns, density, etc) | 🟢 | 🟢 | ⚫ |
Check table pagination and rows per page | 🟢 | 🟢 | ⚫ |
Check document detail flyout | 🟢 | 🟢 | ⚫ |
- Check all table header features (sort, show/hide columns, density, etc)
Chrome 🟢
Evidence_table_header_features_chrome.webm
Firefox 🟢
Evidence_table_header_features_firefox.webm
- Check table pagination and rows per page
Chrome 🟢
Evidence_table_pagination_rowsperpage_chrome.webm
Firefox 🟢
Evidence_table_pagination_rowsperpage_firefox.webm
- Check document detail flyout
jbiset
approved these changes
Jan 9, 2024
TestsSearch bar
Screen.Recording.2024-01-09.at.13.40.52.mov
Screen.Recording.2024-01-09.at.13.41.39.mov
Screen.Recording.2024-01-09.at.13.42.45.mov
Screen.Recording.2024-01-09.at.13.43.05.mov
Screen.Recording.2024-01-09.at.13.43.30.movHistogram chart
Screen.Recording.2024-01-09.at.13.45.10.mov
Screen.Recording.2024-01-09.at.13.45.58.movData grid
Screen.Recording.2024-01-09.at.13.46.29.mov
Screen.Recording.2024-01-09.at.13.47.39.mov
Screen.Recording.2024-01-09.at.13.48.50.mov |
Machi3mfl
approved these changes
Jan 9, 2024
asteriscos
deleted the
feat/6276-replace-discover-configuration-assessment
branch
January 9, 2024 16:59
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR, replaces the events tab on the Configuration assessment module
Issues Resolved
Evidence
Tests
Search bar
add filter
featureNo results match your search criteria
message)saved queries
feature (Check saved queries CRUD)add filter
featureNo results match your search criteria
message)saved queries
feature (Check saved queries CRUD)Histogram chart
Data grid
Check List
yarn test:jest