-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace discover Docker #6286
Merged
Merged
Replace discover Docker #6286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
TestsSearch bar
Screen.Recording.2024-01-09.at.16.16.59.mov
Screen.Recording.2024-01-09.at.16.17.41.mov
Screen.Recording.2024-01-09.at.16.18.18.mov
Screen.Recording.2024-01-09.at.16.19.07.mov
Screen.Recording.2024-01-09.at.16.20.04.movHistogram chart
Screen.Recording.2024-01-09.at.16.20.59.mov
Screen.Recording.2024-01-09.at.16.21.39.movData grid
Screen.Recording.2024-01-09.at.16.22.08.mov
Screen.Recording.2024-01-09.at.16.23.14.mov
Screen.Recording.2024-01-09.at.16.23.54.mov |
Machi3mfl
previously approved these changes
Jan 9, 2024
Machi3mfl
previously approved these changes
Feb 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
CR ✅
Test ✅
Screen.Recording.2024-02-16.at.15.43.57.mov
TestsSearch bar
🟢 Apply filters using search bar input![image](https://github.com/wazuh/wazuh-dashboard-plugins/assets/124377319/6ec0bcf3-ad32-42d2-8730-06b67dcd9bbf)🟢 Apply filters using the search bar `add filter` feature![image](https://github.com/wazuh/wazuh-dashboard-plugins/assets/124377319/fe6fccf9-509f-47a7-b0e6-03b55c9c5dda)🟢 Apply filters using the date picker![image](https://github.com/wazuh/wazuh-dashboard-plugins/assets/124377319/cc63162b-dd71-4a56-aaeb-3e109b213f74)Histogram chart
Data grid
|
JuanGarriuz
previously approved these changes
Feb 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
JuanGarriuz
approved these changes
Feb 20, 2024
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR, replaces the events tab on the Docker module
Issues Resolved
Evidence
Tests
Search bar
add filter
featureNo results match your search criteria
message)saved queries
feature (Check saved queries CRUD)Apply filters using search bar input
Apply filters using the search bar `add filter` feature
Apply filters using the date picker
Apply filters with no results (Check the `No results match your search criteria` message)
Use the `saved queries` feature (Check saved queries CRUD)
Histogram chart
Check histogram chart hits consistency
Use chart options (three points: maximize, minimize, inspect)
Data grid
Check all table header features (sort, show/hide columns, density, etc)
Check table pagination and rows per page
Check document detail flyout
Check List
yarn test:jest