Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace discover file integrity monitoring #6287

Merged
merged 5 commits into from
Jan 10, 2024
Merged

Replace discover file integrity monitoring #6287

merged 5 commits into from
Jan 10, 2024

Conversation

yenienserrano
Copy link
Member

Description

This PR, replaces the events tab on the File integrity monitoringmodule

Issues Resolved

Evidence

image

Tests

Search bar

Test Chrome Firefox Safari
Apply filters using search bar input ⚫ ⚫ ⚫
Apply filters using the search bar add filter feature ⚫ ⚫ ⚫
Apply filters using the date picker ⚫ ⚫ ⚫
Apply filters with no results (Check the No results match your search criteria message) ⚫ ⚫ ⚫
Use the saved queries feature (Check saved queries CRUD) ⚫ ⚫ ⚫
  • Apply filters using search bar input
  • Apply filters using the search bar add filter feature
  • Apply filters using the date picker
  • Apply filters with no results (Check the No results match your search criteria message)
  • Use the saved queries feature (Check saved queries CRUD)

Histogram chart

Test Chrome Firefox Safari
Check histogram chart hits consistency ⚫ ⚫ ⚫
Use chart options (three points: maximize, minimize, inspect) ⚫ ⚫ ⚫
  • Check histogram chart hits consistency
  • Use chart options (three points: maximize, minimize, inspect)

Data grid

Test Chrome Firefox Safari
Check all table header features (sort, show/hide columns, density, etc) ⚫ ⚫ ⚫
Check table pagination and rows per page ⚫ ⚫ ⚫
Check document detail flyout ⚫ ⚫ ⚫
  • Check all table header features (sort, show/hide columns, density, etc)
  • Check table pagination and rows per page
  • Check document detail flyout

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@yenienserrano yenienserrano requested a review from a team as a code owner January 9, 2024 16:06
@yenienserrano yenienserrano linked an issue Jan 9, 2024 that may be closed by this pull request
[Remove discover] Replace discover on file integrity monitoring module #6277
Closed
1 task
@yenienserrano yenienserrano self-assigned this Jan 9, 2024
@Machi3mfl Machi3mfl self-requested a review January 9, 2024 16:54
@Machi3mfl
Copy link
Member

Machi3mfl commented Jan 9, 2024 •
edited
Loading

Tests

Search bar

Test Chrome Firefox Safari
Apply filters using search bar input 🟢 ⚫ ⚫
Apply filters using the search bar add filter feature 🟢 ⚫ ⚫
Apply filters using the date picker 🟢 ⚫ ⚫
Apply filters with no results (Check the No results match your search criteria message) 🟢 ⚫ ⚫
Use the saved queries feature (Check saved queries CRUD) 🟢 ⚫ ⚫
  • Apply filters using search bar input
Screen.Recording.2024-01-09.at.14.09.20.mov
  • Apply filters using the search bar add filter feature
Screen.Recording.2024-01-09.at.14.10.55.mov
  • Apply filters using the date picker
Screen.Recording.2024-01-09.at.14.11.42.mov
  • Apply filters with no results (Check the No results match your search criteria message)
Screen.Recording.2024-01-09.at.14.12.24.mov
  • Use the saved queries feature (Check saved queries CRUD)
Screen.Recording.2024-01-09.at.14.13.14.mov
Screen.Recording.2024-01-09.at.14.14.31.mov

Histogram chart

Test Chrome Firefox Safari
Check histogram chart hits consistency 🟢 ⚫ ⚫
Use chart options (three points: maximize, minimize, inspect) 🟢 ⚫ ⚫
  • Check histogram chart hits consistency
Screen.Recording.2024-01-09.at.14.15.05.mov
  • Use chart options (three points: maximize, minimize, inspect)
Screen.Recording.2024-01-09.at.14.16.02.mov

Data grid

Test Chrome Firefox Safari
Check all table header features (sort, show/hide columns, density, etc) 🟢 ⚫ ⚫
Check table pagination and rows per page 🟢 ⚫ ⚫
Check document detail flyout 🟢 ⚫ ⚫
  • Check all table header features (sort, show/hide columns, density, etc)
Screen.Recording.2024-01-09.at.14.16.32.mov
  • Check table pagination and rows per page
Screen.Recording.2024-01-09.at.14.17.40.mov
  • Check document detail flyout
Screen.Recording.2024-01-09.at.14.18.14.mov

@asteriscos asteriscos self-requested a review January 10, 2024 12:05
@asteriscos
Copy link
Member

Tests

Search bar

Test Chrome Firefox Safari
Apply filters using search bar input 🟢 ⚫ ⚫
Apply filters using the search bar add filter feature 🟢 ⚫ ⚫
Apply filters using the date picker 🟢 ⚫ ⚫
Apply filters with no results (Check the No results match your search criteria message) 🟢 ⚫ ⚫
Use the saved queries feature (Check saved queries CRUD) 🟢 ⚫ ⚫
  • Apply filters using search bar input

image

  • Apply filters using the search bar add filter feature

image

  • Apply filters using the date picker

image

  • Apply filters with no results (Check the No results match your search criteria message)

image

  • Use the saved queries feature (Check saved queries CRUD)
Peek.2024-01-10.13-30.mp4

Histogram chart

Test Chrome Firefox Safari
Check histogram chart hits consistency 🟢 ⚫ ⚫
Use chart options (three points: maximize, minimize, inspect) 🟢 ⚫ ⚫
  • Check histogram chart hits consistency

image

image

  • Use chart options (three points: maximize, minimize, inspect)

image

Data grid

Test Chrome Firefox Safari
Check all table header features (sort, show/hide columns, density, etc) 🟢 ⚫ ⚫
Check table pagination and rows per page 🟢 ⚫ ⚫
Check document detail flyout 🟢 ⚫ ⚫
  • Check all table header features (sort, show/hide columns, density, etc)

image

  • Check table pagination and rows per page

image

  • Check document detail flyout

image

asteriscos
asteriscos approved these changes Jan 10, 2024
View reviewed changes
Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✔️
Test: ✔️

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.33% ( 171 / 224 )
Branches 57.57% ( 57 / 99 )
Functions 61.7% ( 29 / 47 )
Lines 76.33% ( 171 / 224 )

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 22.02% ( 176 / 799 )
Branches 19.55% ( 79 / 404 )
Functions 14.63% ( 36 / 246 )
Lines 22.23% ( 173 / 778 )

@github-actions GitHub Actions
Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 11.41% ( 3918 / 34335 )
Branches 7.55% ( 1715 / 22687 )
Functions 11% ( 903 / 8204 )
Lines 11.58% ( 3807 / 32872 )

@asteriscos asteriscos merged commit 5382600 into master Jan 10, 2024
4 checks passed
@asteriscos asteriscos deleted the feat/6277-replace-discover-fim branch January 10, 2024 18:02
@asteriscos asteriscos mentioned this pull request Aug 21, 2024
Closed
74 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asteriscos asteriscos asteriscos approved these changes

@Machi3mfl Machi3mfl Machi3mfl approved these changes

Assignees

@yenienserrano yenienserrano

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Remove discover] Replace discover on file integrity monitoring module
3 participants
@yenienserrano @Machi3mfl @asteriscos