Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace discover AWS #6288

Merged
merged 9 commits into from
Feb 15, 2024
Merged

Replace discover AWS #6288

merged 9 commits into from
Feb 15, 2024

Conversation

yenienserrano
Copy link
Member

Description

This PR, replaces the events tab on the Amazon Web Services module

Issues Resolved

Evidence

image

Tests

Search bar

Test Chrome Firefox Safari
Apply filters using search bar input
Apply filters using the search bar add filter feature
Apply filters using the date picker
Apply filters with no results (Check the No results match your search criteria message)
Use the saved queries feature (Check saved queries CRUD)
  • Apply filters using search bar input
  • Apply filters using the search bar add filter feature
  • Apply filters using the date picker
  • Apply filters with no results (Check the No results match your search criteria message)
  • Use the saved queries feature (Check saved queries CRUD)

Histogram chart

Test Chrome Firefox Safari
Check histogram chart hits consistency
Use chart options (three points: maximize, minimize, inspect)
  • Check histogram chart hits consistency
  • Use chart options (three points: maximize, minimize, inspect)

Data grid

Test Chrome Firefox Safari
Check all table header features (sort, show/hide columns, density, etc)
Check table pagination and rows per page
Check document detail flyout
  • Check all table header features (sort, show/hide columns, density, etc)
  • Check table pagination and rows per page
  • Check document detail flyout

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@yenienserrano yenienserrano requested a review from a team as a code owner January 9, 2024 16:19
@yenienserrano yenienserrano self-assigned this Jan 9, 2024
@yenienserrano yenienserrano linked an issue Jan 9, 2024 that may be closed by this pull request
1 task
@Machi3mfl Machi3mfl self-requested a review January 10, 2024 12:59
Copy link
Member

@Machi3mfl Machi3mfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests

Search bar

Test Chrome Firefox Safari
Apply filters using search bar input 🟢
Apply filters using the search bar add filter feature 🟢
Apply filters using the date picker 🟢
Apply filters with no results (Check the No results match your search criteria message) 🟢
Use the saved queries feature (Check saved queries CRUD) 🟢
  • Apply filters using search bar input
Screen.Recording.2024-01-10.at.14.18.28.mov
  • Apply filters using the search bar add filter feature
Screen.Recording.2024-01-10.at.14.20.50.mov
  • Apply filters using the date picker
Screen.Recording.2024-01-10.at.14.22.03.mov
  • Apply filters with no results (Check the No results match your search criteria message)
Screen.Recording.2024-01-10.at.14.17.30.mov
  • Use the saved queries feature (Check saved queries CRUD)
Screen.Recording.2024-01-10.at.14.22.53.mov

Histogram chart

Test Chrome Firefox Safari
Check histogram chart hits consistency 🟢
Use chart options (three points: maximize, minimize, inspect) 🟢
  • Check histogram chart hits consistency
Screen.Recording.2024-01-10.at.14.24.15.mov
  • Use chart options (three points: maximize, minimize, inspect)
Screen.Recording.2024-01-10.at.14.25.30.mov

Data grid

Test Chrome Firefox Safari
Check all table header features (sort, show/hide columns, density, etc) 🟢
Check table pagination and rows per page 🟢
Check document detail flyout 🟢
  • Check all table header features (sort, show/hide columns, density, etc)
Screen.Recording.2024-01-10.at.14.27.00.mov
  • Check table pagination and rows per page
Screen.Recording.2024-01-10.at.14.28.56.mov
  • Check document detail flyout
Screenshot 2024-02-15 at 11 47 28

@yenienserrano
Copy link
Member Author

Looking at the bug commented out in the test, I have seen some problems in the flyout. For example, when the field has a very long name, it pushes the value column, leaving it with little space, it was also missing the styles to the table.

Possible solutions

image

image

Copy link
Contributor

github-actions bot commented Feb 9, 2024

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

Copy link
Contributor

github-actions bot commented Feb 9, 2024

Wazuh Core plugin code coverage (Jest) test % values
Statements 21.38% ( 176 / 823 )
Branches 19.45% ( 79 / 406 )
Functions 14.17% ( 36 / 254 )
Lines 21.57% ( 173 / 802 )

Copy link
Contributor

github-actions bot commented Feb 9, 2024

Main plugin code coverage (Jest) test % values
Statements 11.62% ( 4008 / 34491 )
Branches 7.7% ( 1753 / 22760 )
Functions 11.2% ( 925 / 8257 )
Lines 11.79% ( 3896 / 33031 )

@asteriscos asteriscos changed the base branch from master to 4.9.0 February 13, 2024 09:56
@Machi3mfl
Copy link
Member

Looking at the bug commented out in the test, I have seen some problems in the flyout. For example, when the field has a very long name, it pushes the value column, leaving it with little space, it was also missing the styles to the table.

Possible solutions

image

image

nice, @yenienserrano. Good job

Screenshot 2024-02-15 at 11 47 28

Copy link
Member

@Machi3mfl Machi3mfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR ✅
Testing ✅

@Tostti
Copy link
Member

Tostti commented Feb 15, 2024

Tests

Search bar

Test Chrome Firefox Safari
Apply filters using search bar input 🟢
Apply filters using the search bar add filter feature 🟢
Apply filters using the date picker 🟢
Apply filters with no results (Check the No results match your search criteria message) 🟢
Use the saved queries feature (Check saved queries CRUD) 🟢

Histogram chart

Test Chrome Firefox Safari
Check histogram chart hits consistency 🟢
Use chart options (three points: maximize, minimize, inspect) 🟢
  • Check histogram chart hits consistency

Data grid

Test Chrome Firefox Safari
Check all table header features (sort, show/hide columns, density, etc) 🟢
Check table pagination and rows per page 🟢
Check document detail flyout 🟢
Video_2024-02-15_12-22-50.mp4

Copy link
Member

@Tostti Tostti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test ✅
CR ✅

LGTM

@Machi3mfl Machi3mfl merged commit ac50517 into 4.9.0 Feb 15, 2024
4 checks passed
@Machi3mfl Machi3mfl deleted the feat/6279-replace-discover-aws branch February 15, 2024 15:56
@asteriscos asteriscos mentioned this pull request Aug 21, 2024
74 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Remove discover] Replace discover on AWS module
5 participants