Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace discover Google cloud #6289

Merged
merged 7 commits into from
Feb 19, 2024
Merged

Replace discover Google cloud #6289

merged 7 commits into from
Feb 19, 2024

Conversation

yenienserrano
Copy link
Member

@yenienserrano yenienserrano commented Jan 9, 2024 •
edited
Loading

Description

This PR, replaces the events tab on the Google cloud module

Issues Resolved

Evidence

image

Tests

Search bar

Test Chrome Firefox Safari
Apply filters using search bar input ⚫ ⚫ ⚫
Apply filters using the search bar add filter feature ⚫ ⚫ ⚫
Apply filters using the date picker ⚫ ⚫ ⚫
Apply filters with no results (Check the No results match your search criteria message) ⚫ ⚫ ⚫
Use the saved queries feature (Check saved queries CRUD) ⚫ ⚫ ⚫
  • Apply filters using search bar input
  • Apply filters using the search bar add filter feature
  • Apply filters using the date picker
  • Apply filters with no results (Check the No results match your search criteria message)
  • Use the saved queries feature (Check saved queries CRUD)

Histogram chart

Test Chrome Firefox Safari
Check histogram chart hits consistency ⚫ ⚫ ⚫
Use chart options (three points: maximize, minimize, inspect) ⚫ ⚫ ⚫
  • Check histogram chart hits consistency
  • Use chart options (three points: maximize, minimize, inspect)

Data grid

Test Chrome Firefox Safari
Check all table header features (sort, show/hide columns, density, etc) ⚫ ⚫ ⚫
Check table pagination and rows per page ⚫ ⚫ ⚫
Check document detail flyout ⚫ ⚫ ⚫
  • Check all table header features (sort, show/hide columns, density, etc)
  • Check table pagination and rows per page
  • Check document detail flyout

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@yenienserrano yenienserrano requested a review from a team as a code owner January 9, 2024 16:50
@yenienserrano yenienserrano self-assigned this Jan 9, 2024
@yenienserrano yenienserrano linked an issue Jan 9, 2024 that may be closed by this pull request
[Remove discover] Replace discover on Google cloud module #6280
Closed
1 task
@Machi3mfl Machi3mfl self-requested a review January 10, 2024 17:35
Machi3mfl
Machi3mfl requested changes Jan 10, 2024
View reviewed changes
Copy link
Member

@Machi3mfl Machi3mfl left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests

Search bar

Test Chrome Firefox Safari
Apply filters using search bar input 🟢 ⚫ ⚫
Apply filters using the search bar add filter feature 🟢 ⚫ ⚫
Apply filters using the date picker 🟢 ⚫ ⚫
Apply filters with no results (Check the No results match your search criteria message) 🟢 ⚫ ⚫
Use the saved queries feature (Check saved queries CRUD) 🟢 ⚫ ⚫
  • Apply filters using search bar input
Screen.Recording.2024-01-10.at.14.39.59.mov
  • Apply filters using the search bar add filter feature
Screen.Recording.2024-01-10.at.14.40.52.mov
  • Apply filters using the date picker
Screen.Recording.2024-01-10.at.14.42.48.mov
  • Apply filters with no results (Check the No results match your search criteria message)
Screen.Recording.2024-01-10.at.14.43.11.mov
  • Use the saved queries feature (Check saved queries CRUD)
Screen.Recording.2024-01-10.at.14.43.36.mov

Histogram chart

Test Chrome Firefox Safari
Check histogram chart hits consistency 🟢 ⚫ ⚫
Use chart options (three points: maximize, minimize, inspect) 🟢 ⚫ ⚫
  • Check histogram chart hits consistency
Screen.Recording.2024-01-10.at.14.44.17.mov
  • Use chart options (three points: maximize, minimize, inspect)
Screen.Recording.2024-01-10.at.14.44.51.mov

Data grid

Test Chrome Firefox Safari
Check all table header features (sort, show/hide columns, density, etc) 🟢 ⚫ ⚫
Check table pagination and rows per page 🟢 ⚫ ⚫
Check document detail flyout 🟢 ⚫ ⚫
  • Check all table header features (sort, show/hide columns, density, etc)

Error when show all columns is clicked

Screen.Recording.2024-01-10.at.14.46.26.mov
Screenshot 2024-01-10 at 14 47 31

Fixed

Screen Recording 2024-02-16 at 14.38.02

  • Check table pagination and rows per page
Screen.Recording.2024-01-10.at.14.48.05.mov
  • Check document detail flyout
Screen.Recording.2024-01-10.at.14.48.34.mov

@JuanGarriuz
Copy link
Member

JuanGarriuz commented Feb 2, 2024 •
edited
Loading

Tests

Search bar

Test Chrome Firefox Safari
Apply filters using search bar input 🟢 ⚫ ⚫
Apply filters using the search bar add filter feature 🟢 ⚫ ⚫
Apply filters using the date picker 🟢 ⚫ ⚫
Apply filters with no results (Check the No results match your search criteria message) 🟢 ⚫ ⚫
Use the saved queries feature (Check saved queries CRUD) 🟡 ⚫ ⚫
🟢Apply filters using search bar input

image

🟢Apply filters using the search bar `add filter` feature

image
image
image

🟢Apply filters using the date picker

image
image

🟢Apply filters with no results (Check the `No results match your search criteria` message)

image

🟡 Use the `saved queries` feature (Check saved queries CRUD)

image

image

image

When using the clear of the save query, filters that perhaps should be maintained are removed.

image

Histogram chart

Test Chrome Firefox Safari
Check histogram chart hits consistency 🟢 ⚫ ⚫
Use chart options (three points: maximize, minimize, inspect) 🟡 ⚫ ⚫
🟢Check histogram chart hits consistency

image
image

🟡Use chart options (three points: maximize, minimize, inspect)

image

It's more of a visual bug, but the data is marked as if it's in a continuous hover state, giving the impression that you are on that tab.

test.data.mp4

Data grid

Test Chrome Firefox Safari
Check all table header features (sort, show/hide columns, density, etc) 🟢 ⚫ ⚫
Check table pagination and rows per page 🟢 ⚫ ⚫
Check document detail flyout 🟢 ⚫ ⚫
🟢Check all table header features (sort, show/hide columns, density, etc)

image
image
image
image
image
image

🟢Check table pagination and rows per page

image
image

🟢Check document detail flyout

image

@yenienserrano
Copy link
Member Author

Tests

Search bar

Test Chrome Firefox Safari
Apply filters using search bar input 🟢 ⚫ ⚫
Apply filters using the search bar add filter feature 🟢 ⚫ ⚫
Apply filters using the date picker 🟢 ⚫ ⚫
Apply filters with no results (Check the No results match your search criteria message) 🟢 ⚫ ⚫
Use the saved queries feature (Check saved queries CRUD) 🟢 ⚫ ⚫

  • Apply filters using search bar input

  • Apply filters using the search bar add filter feature

  • Apply filters using the date picker

  • Apply filters with no results (Check the No results match your search criteria message)

  • Use the saved queries feature (Check saved queries CRUD)

Histogram chart

Test Chrome Firefox Safari
Check histogram chart hits consistency 🟢 ⚫ ⚫
Use chart options (three points: maximize, minimize, inspect) 🟢 ⚫ ⚫

  • Check histogram chart hits consistency

  • Use chart options (three points: maximize, minimize, inspect)

Data grid

Test Chrome Firefox Safari
Check all table header features (sort, show/hide columns, density, etc) 🔴 ⚫ ⚫
Check table pagination and rows per page 🟢 ⚫ ⚫
Check document detail flyout 🟢 ⚫ ⚫

  • Check all table header features (sort, show/hide columns, density, etc)

  • Check table pagination and rows per page

  • Check document detail flyout

the problem is fixed in this PR

@asteriscos asteriscos changed the base branch from master to 4.9.0 February 13, 2024 09:57
@github-actions GitHub Actions
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 21.38% ( 176 / 823 )
Branches 19.45% ( 79 / 406 )
Functions 14.17% ( 36 / 254 )
Lines 21.57% ( 173 / 802 )

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

@github-actions GitHub Actions
Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 11.62% ( 4008 / 34492 )
Branches 7.7% ( 1753 / 22760 )
Functions 11.2% ( 925 / 8257 )
Lines 11.79% ( 3896 / 33032 )

@Machi3mfl
Copy link
Member

Tested the fixes made by @yenienserrano

Screenshot 2024-02-16 at 14 37 42
Screen.Recording.2024-02-16.at.14.38.02.mov

JuanGarriuz
JuanGarriuz approved these changes Feb 19, 2024
View reviewed changes
Copy link
Member

@JuanGarriuz JuanGarriuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

@Desvelao Desvelao merged commit 8513a23 into 4.9.0 Feb 19, 2024
4 checks passed
@Desvelao Desvelao deleted the feat/6280-replace-discover-google-cloud branch February 19, 2024 12:23
@asteriscos asteriscos mentioned this pull request Aug 21, 2024
Closed
74 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JuanGarriuz JuanGarriuz JuanGarriuz approved these changes

@Machi3mfl Machi3mfl Machi3mfl approved these changes

Assignees

@yenienserrano yenienserrano

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Remove discover] Replace discover on Google cloud module
5 participants
@yenienserrano @JuanGarriuz @Machi3mfl @Desvelao @jbiset