-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove discover implement embeddable dashboard on aws module #6494
Merged
Tostti
merged 29 commits into
4.9.0
from
6493-remove-discover-implement-embeddable-dashboard-on-aws-module
Apr 26, 2024
Merged
Remove discover implement embeddable dashboard on aws module #6494
Tostti
merged 29 commits into
4.9.0
from
6493-remove-discover-implement-embeddable-dashboard-on-aws-module
Apr 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
yenienserrano
changed the title
6493 remove discover implement embeddable dashboard on aws module
Remove discover implement embeddable dashboard on aws module
Mar 11, 2024
|
|
|
…ashboard-on-aws-module
TestGlobal
🟢 Check the request with hidden filters applied (allow agents, hide manager alerts)`Enable/disable the hideManagerAlerts settings on App Settings`Dashboard tab
🟢 Use search bar input to filter any word and check if the dashboard shows the corresponding results🟢 Select an option from one of the recommended filters and check that the corresponding filter is added and the dashboard changes according to the applied filterEvents tab (Discover)Search bar
Histogram chart
Data grid
|
…ashboard-on-aws-module
JuanGarriuz
previously approved these changes
Apr 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!!!
…ashboard-on-aws-module
…ashboard-on-aws-module
JuanGarriuz
previously approved these changes
Apr 25, 2024
jbiset
reviewed
Apr 25, 2024
plugins/main/public/components/overview/amazon-web-services/dashboards/styles.scss
Outdated
Show resolved
Hide resolved
CR: 🟢Test UI: 🟢Global
Chrome 🟢Global_1_Chrome.webmFirefox 🟢Global_1_Firefox.webm
Chrome 🟢Global_2_Chrome.webmFirefox 🟢Global_2_Firefox.webm
Dashboard tab
Chrome 🟢Dashboard_1_Chrome.webmFirefox 🟢Dashboard_1_Firefox.webm
Chrome 🟢Dashboard_2_Chrome.webmFirefox 🟢Dashboard_2_Firefox.webm
Chrome 🟢Dashboard_3_Chrome.webmFirefox 🟢Dashboard_3_Firefox.webm
Events tab (Discover)Search bar
Chrome 🟢Events_1_Chrome.webmFirefox 🟢Events_1_Firefox.webm
Chrome 🟢Events_2_Chrome.webmFirefox 🟢Events_2_Firefox.webm
Chrome 🟢Events_3_Chrome.webmFirefox 🟢Events_3_Firefox.webm
Chrome 🟢Events_4_Chrome.webmFirefox 🟢Events_4_Firefox.webmHistogram chart
Chrome 🟢Histogram_1_Chrome.webmFirefox 🟢Histogram_1_Firefox.webmData grid
The behavior of moving columns is not correct Chrome 🟡DataGrid_1_Chrome.webmFirefox 🟡DataGrid_1_Firefox.webm
Chrome 🟢DataGrid_2_Chrome.webmFirefox 🟢DataGrid_2_Firefox.webm
|
…ashboard-on-aws-module
jbiset
previously approved these changes
Apr 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
JuanGarriuz
previously approved these changes
Apr 26, 2024
…ashboard-on-aws-module
jbiset
approved these changes
Apr 26, 2024
Tostti
deleted the
6493-remove-discover-implement-embeddable-dashboard-on-aws-module
branch
April 26, 2024 17:12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
implement the embeddable dashboard on AWS -> dashboard tab and deprecate any use of kibana-integrations components.
Issues Resolved
Evidence
Test
Global
Enable/disable the hideManagerAlerts settings on App Settings
Dashboard tab
Events tab (Discover)
Search bar
add filter
featureNo results match your search criteria
message)saved queries
feature (Check saved queries CRUD)add filter
featureNo results match your search criteria
message)saved queries
feature (Check saved queries CRUD)Histogram chart
Data grid
Check List
yarn test:jest